[Transaction] Fix MLTransactionLog open manageLedger name problem. - #10334
Merged
codelipenghui merged 2 commits intoApr 23, 2021
Merged
Conversation
eolivelli
requested changes
Apr 23, 2021
eolivelli
left a comment
eolivelli
left a comment
Contributor
There was a problem hiding this comment.
Awesome.
I left some minor comments
| && !checkTopicIsEventsNames(topic) | ||
| && !topic.contains(TopicName.TRANSACTION_COORDINATOR_ASSIGN.getLocalName())) { | ||
| && !topic.contains(TopicName.TRANSACTION_COORDINATOR_ASSIGN.getLocalName()) | ||
| && !topic.contains(MLTransactionLogImpl.TRANSACTION_LOG_PREFIX)) { |
| managedLedgerConfig.setMaxEntriesPerLedger(2); | ||
| new MLTransactionLogImpl(TransactionCoordinatorID.get(0), | ||
| pulsar.getManagedLedgerFactory(), managedLedgerConfig); | ||
| Thread.sleep(2000); |
Contributor
There was a problem hiding this comment.
Why do you need this sleep? Can we replace with Awaiatility in order to make the test more resilient?
Contributor
Author
There was a problem hiding this comment.
don't need sleep, I did not check again.
codelipenghui
approved these changes
Apr 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
now
MLTransactionLoggeneratemanagedLedgername is illegal.implement
generate correct name and can generate metrics.
Verifying this change
Add the tests for it
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes
Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (no)
The default values of configurations: (no)
The wire protocol: (no)
The rest endpoints: (no)
The admin cli options: (no)
Anything that affects deployment: (no)