Fixes function api can not use authdata to check superuser#10364
Merged
Conversation
--- Fixes apache#10332 *Motivation* Sometimes, the superuser is not only needed the client role but also needs some data in the authentication data to check whether the role is the superuser.
zymap
requested review from
codelipenghui,
jerrypeng,
sijie,
srkukarni and
wolfstudy
April 25, 2021 12:12
fantapsody
approved these changes
Apr 26, 2021
fantapsody
left a comment
fantapsody
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks for the fix!
Member
Author
|
ping @freeznet @codelipenghui @sijie PTAL. Thanks |
jerrypeng
approved these changes
Apr 29, 2021
sijie
approved these changes
May 4, 2021
eolivelli
pushed a commit
to eolivelli/pulsar
that referenced
this pull request
May 11, 2021
) --- Fixes apache#10332 *Motivation* Sometimes, the superuser is not only needed the client role but also needs some data in the authentication data to check whether the role is the superuser. The changed interface is introduced from apache#8560, it's safe to change it since there is no release for that.
zymap
added a commit
to zymap/pulsar
that referenced
this pull request
Jul 22, 2021
--- *Motivation* Port the fix apache#10364 to the branch 2.7. Sometimes, the superuser is not only needed the client role but also needs some data in the authentication data to check whether the role is the superuser. The changed interface is introduced from apache#8560, it's safe to change it since there is no release for that.' *Modifications* Change the isSuperUser method to accept the authenticationData and pass it to the authentication provider. So authenticatoin prodiver can get the data saved in the authenticationDataSource.
1 task
zymap
added a commit
that referenced
this pull request
Jul 22, 2021
…er (#11418) --- *Motivation* Port the fix #10364 to the branch 2.7. Sometimes, the superuser is not only needed the client role but also needs some data in the authentication data to check whether the role is the superuser. The changed interface is introduced from #8560, it's safe to change it since there is no release for that.' *Modifications* Change the isSuperUser method to accept the authenticationData and pass it to the authentication provider. So authenticatoin prodiver can get the data saved in the authenticationDataSource.
jerrypeng
pushed a commit
to jerrypeng/incubator-pulsar
that referenced
this pull request
Nov 4, 2021
) --- Fixes apache#10332 *Motivation* Sometimes, the superuser is not only needed the client role but also needs some data in the authentication data to check whether the role is the superuser. The changed interface is introduced from apache#8560, it's safe to change it since there is no release for that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10332
Motivation
Sometimes, the superuser is not only needed the client
role but also needs some data in the authentication data
to check whether the role is the superuser.
The changed interface is introduced from #8560,
it's safe to change it since there is no release for that.