[fix #9640] remove pulsar-client-admin-api dependency : pulsar-package-core - #10538
Merged
merlimat merged 1 commit intoMay 11, 2021
Conversation
freeznet
force-pushed
the
freeznet/9640-remove-client-admin-api-dependency-pulsar-package-core
branch
from
May 11, 2021 07:28
4c5996b to
38e9685
Compare
Contributor
Author
|
/pulsarbot run-failure-checks |
jiazhai
approved these changes
May 11, 2021
hangc0276
approved these changes
May 11, 2021
Contributor
Author
|
@sijie @merlimat @jerrypeng @zymap @lhotari please help to review this PR if you have time, thanks. |
merlimat
approved these changes
May 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9640
Part 2
Motivation
Module
pulsar-client-admin-apihas been introduced in #9246, but it pulling in many dependencies. That is undesirable for an "API" module.This PR removes
pulsar-package-corefrom the dependency, and resolves the issues. Later there will be sepreate PRs to remove other dependencies likepulsar-common.#10513 removes
pulsar-client-original.Modifications
remove
pulsar-package-corefrompulsar-client-admin-api.Verifying this change