Skip to content

Fix flaky test GracefulExecutorServicesShutdownTest.shouldTerminateWhenFutureIsCancelled #10592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lhotari merged 2 commits into from
May 14, 2021
Merged

Fix flaky test GracefulExecutorServicesShutdownTest.shouldTerminateWhenFutureIsCancelled #10592

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78b3655
fix flaky test GracefulExecutorServicesShutdownTest.shouldTerminateWh…
linlinnn May 14, 2021
50938ed
avoid import *
linlinnn May 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .../src/test/java/org/apache/pulsar/broker/service/GracefulExecutorServicesShutdownTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
import java.util.concurrent.TimeoutException;
import java.util.concurrent.atomic.AtomicBoolean;
import org.testng.annotations.Test;
import org.awaitility.Awaitility;

public class GracefulExecutorServicesShutdownTest {

Expand Down Expand Up @@ -151,8 +152,8 @@ public void shouldTerminateWhenFutureIsCancelled() throws InterruptedException {
future.cancel(false);

// then
assertTrue(awaitTerminationInterrupted.get(),
"awaitTermination should have been interrupted");
Awaitility.await().untilAsserted(() -> assertTrue(awaitTerminationInterrupted.get(),
"awaitTermination should have been interrupted"));
verify(executorService, times(1)).awaitTermination(anyLong(), any());
verify(executorService, times(1)).shutdownNow();
}
Expand Down