[ Issue 11032 ] Fixed flaky test ZKSessionTest.. #11032 - #11062
Merged
Conversation
In some cases, testing errors occurred due to Zookeeper's notification delay. - Waiting async notice until timeout.
sijie
approved these changes
Jun 24, 2021
Member
Author
|
/pulsarbot rerun-failure-checks |
eolivelli
requested changes
Jun 24, 2021
eolivelli
left a comment
eolivelli
left a comment
Contributor
There was a problem hiding this comment.
thank you for helping with this fix.
overall LGTM
but can you please take a look to my comments ?
315157973
reviewed
Jun 24, 2021
Firstly,This test to validate leader election after session is recovered. I think the leaderElectionEvenets check is unstable in here. eg: 1.When the node state is late to update => node state = Leading, leaderElectionEvents is empty. 2.When a node has been elected as the leader => node sate = Leading, leaderElectionEvents = [noLeader,Leading/Following]. 3.Leader election may be triggered at any time.(It may be just after the election due to network delays). - Delete leaderElectionEvents null check. - Waiting for node can be leader after session expire.
Member
Author
|
Firstly, This test validates leader election after the session is recovered. |
Member
Author
|
If I understand it wrong, please give me some guidance. @315157973 @lhotari @eolivelli |
- remove redundant test
…ilover (#10786) Replaced check after sleep to `untilAsserted` and extended `atMost` time to 10 seconds(default of `Awaitility`).
lhotari
approved these changes
Jun 24, 2021
eolivelli
reviewed
Jun 24, 2021
- Delete useless code.
Member
Author
|
@eolivelli Could you review again? |
eolivelli
approved these changes
Jun 29, 2021
Contributor
|
please @315157973 take another look |
Member
Author
|
@315157973 PTAL |
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
…#11062) Fixes apache#11032 apache#11143 Master Issue: apache#11032 apache#11143 Motivation In some cases, testing errors occurred due to Zookeeper's notification delay. Modifications Waiting async notice until timeout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11032 #11143
Master Issue: #11032 #11143
Motivation
In some cases, testing errors occurred due to Zookeeper's notification delay.
Modifications
Waiting async notice until timeout.