Fix Flaky-test: [LoadBalancerTest].[testBrokerRanking]#11150
Merged
Conversation
Contributor
Author
|
ping @codelipenghui |
Contributor
Author
|
cc @gaoran10.. |
eolivelli
requested changes
Jun 30, 2021
eolivelli
left a comment
eolivelli
left a comment
Contributor
There was a problem hiding this comment.
great to see the test fixed.
thank you !
I am concerned with the change about dynamic configuration.
do we need that change in order to make the test less flaky ?
otherwise I believe it is better to split the patch into two parts
Contributor
Author
Thanks, I will split the patch, update later. |
eolivelli
requested changes
Jun 30, 2021
eolivelli
approved these changes
Jun 30, 2021
eolivelli
reviewed
Jun 30, 2021
sijie
approved these changes
Jun 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.