fix compaction entry read exception#11175
Merged
eolivelli merged 2 commits intoJul 2, 2021
Merged
Conversation
hangc0276
requested review from
315157973,
codelipenghui,
eolivelli,
lhotari and
sijie
July 1, 2021 05:00
codelipenghui
approved these changes
Jul 1, 2021
codelipenghui
left a comment
Contributor
There was a problem hiding this comment.
The change looks good to me, is it able to add a test for avoiding the regression?
315157973
approved these changes
Jul 1, 2021
eolivelli
approved these changes
Jul 2, 2021
codelipenghui
pushed a commit
that referenced
this pull request
Jul 4, 2021
(cherry picked from commit c716495)
codelipenghui
pushed a commit
that referenced
this pull request
Jul 7, 2021
(cherry picked from commit c716495)
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When read entry from compacted ledger, it will get the following exception when read the end of compacted ledger
The reason is when
startPoint == NEWER_THAN_COMPACTEDit will set cursor to normal ledger to read the following entry and should just complete the read cycle and return.pulsar/pulsar-broker/src/main/java/org/apache/pulsar/compaction/CompactedTopicImpl.java
Lines 109 to 118 in e9c5476
Modification