[C++] Use same regex code at ZTSClient#11323
Merged
Merged
Conversation
Contributor
Author
|
/pulsarbot run-failure-checks |
1 similar comment
Contributor
Author
|
/pulsarbot run-failure-checks |
BewareMyPower
approved these changes
Jul 15, 2021
Member
|
Thanks for your contribution. For this PR, do we need to update docs? (The PR template contains info about doc, which helps others know more about the changes. Can you provide doc info in future PR descriptions? Thanks) |
Contributor
Author
I understand. I updated the description. |
Member
|
@equanz many thanks! |
nkurihar
approved these changes
Jul 19, 2021
sijie
approved these changes
Jul 19, 2021
lhotari
added a commit
to lhotari/pulsar
that referenced
this pull request
Jul 21, 2021
This reverts commit 7cce8e3.
Technoboy-
pushed a commit
to Technoboy-/pulsar
that referenced
this pull request
Jul 22, 2021
### Motivation apache#9533 causes some degraded behaviors at [ZTSClient](https://github.com/apache/pulsar/pull/9533/files#diff-41a90a5ec7937b5e2151752843621d6acfe8963077dc04c285842a09a4e45ecc). 1. when using boost::regex - can't set `path` at file scheme 2. when using std::regex - can't set relative path like `file:./path/to/private.key` I'd like to fix this issue. ### Modifications * Use same regex code between boost and std like [this](https://github.com/apache/pulsar/pull/9533/files#diff-a67e917f5f42f3337507a69a4e0f13e286238dc759b4048cb5141290cf445b38) * Fix regex to be able to capture relative path like `file:./`
codelipenghui
pushed a commit
that referenced
this pull request
Jul 23, 2021
### Motivation #9533 causes some degraded behaviors at [ZTSClient](https://github.com/apache/pulsar/pull/9533/files#diff-41a90a5ec7937b5e2151752843621d6acfe8963077dc04c285842a09a4e45ecc). 1. when using boost::regex - can't set `path` at file scheme 2. when using std::regex - can't set relative path like `file:./path/to/private.key` I'd like to fix this issue. ### Modifications * Use same regex code between boost and std like [this](https://github.com/apache/pulsar/pull/9533/files#diff-a67e917f5f42f3337507a69a4e0f13e286238dc759b4048cb5141290cf445b38) * Fix regex to be able to capture relative path like `file:./` (cherry picked from commit 7cce8e3)
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
### Motivation apache#9533 causes some degraded behaviors at [ZTSClient](https://github.com/apache/pulsar/pull/9533/files#diff-41a90a5ec7937b5e2151752843621d6acfe8963077dc04c285842a09a4e45ecc). 1. when using boost::regex - can't set `path` at file scheme 2. when using std::regex - can't set relative path like `file:./path/to/private.key` I'd like to fix this issue. ### Modifications * Use same regex code between boost and std like [this](https://github.com/apache/pulsar/pull/9533/files#diff-a67e917f5f42f3337507a69a4e0f13e286238dc759b4048cb5141290cf445b38) * Fix regex to be able to capture relative path like `file:./`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
#9533 causes some degraded behaviors at ZTSClient.
pathat file schemefile:./path/to/private.keyI'd like to fix this issue.
Modifications
file:./Verifying this change
This change added tests and can be verified as follows:
ZTSClientWrapper::parseUriwith relative pathDoes this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
For contributor
For this PR, do we need to update docs?
No. Because this is one of the bug fixes.
For committer
For this PR, do we need to update docs?
doclabel.doc-requiredlabel.doc-requiredlabel.no-need-doclabel and explain why.