Fixed inconsistent behavior for Namespace bundles cache#11346
Merged
Conversation
merlimat
added
type/bug
codelipenghui
approved these changes
Jul 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In 2.7 there's a bug that leave the Namespace bundles cache to not to be invalidated after a namespace is deleted.
If a namespace is deleted and recreated with a different number of bundles, that will lead to ownership issues.
The main problem is that we're invalidating the bundle cache immediately and it will get re-insterted with the old version of the z-node, therefore discarding the new updates.
This is targeting branch 2.7 since the code has changed quite a bit in 2.8. I'll also add the same test in master branch.