Skip to content

[docs]Update deploy-bare-metal.md#11452

Merged
Jennifer88huang-zz merged 17 commits into
apache:masterfrom
fengtao1998:patch-6
Aug 10, 2021
Merged

[docs]Update deploy-bare-metal.md#11452
Jennifer88huang-zz merged 17 commits into
apache:masterfrom
fengtao1998:patch-6

Conversation

@fengtao1998

@fengtao1998 fengtao1998 commented Jul 24, 2021

Copy link
Copy Markdown
Contributor

Revise official documents to make them easy to understand and use
Update deploy-bare-metal.md

@Jennifer88huang-zz
Jennifer88huang-zz requested review from Anonymitaet and murong00 and removed request for Anonymitaet July 26, 2021 01:19
@Jennifer88huang-zz Jennifer88huang-zz added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Jul 26, 2021
@Jennifer88huang-zz Jennifer88huang-zz added this to the 2.9.0 milestone Jul 26, 2021
Jennifer88huang-zz
Jennifer88huang-zz reviewed Jul 26, 2021
View reviewed changes

@Jennifer88huang-zz Jennifer88huang-zz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • From L8-20, we add some tips, is it good practice to begin a topic with lots of tips?
  • From L24-27, if they are in order, you can use order list for them.
  • "Each machine in your cluster needs to have Java 8 or Java 11 installed.": it's better to use active voice, such as "You need to install Java 8 or Java 11 on each machine in your cluster". Keep in mind that the task is conducted by "users /you".

Comment thread site2/docs/deploy-bare-metal.md Outdated
Comment thread site2/docs/deploy-bare-metal.md
Comment thread site2/docs/deploy-bare-metal.md Outdated
Comment thread site2/docs/deploy-bare-metal.md
@Jennifer88huang-zz

Jennifer88huang-zz commented Jul 26, 2021

Copy link
Copy Markdown
Contributor

@fengtao1998 Generally good job~
You can also refine the structure, and consider the following things:

  • Requirements
    • Software requirements
    • Hardware requirements
      This guides can be used as reference for restructure.
  1. Before deployment, there list some content on how to install Pulsar, Connector, tiered storage. Are they duplication of what's "Run Pulsar locally"? If yes, shall we reuse the content and use link instead?

fengtao1998 and others added 3 commits July 27, 2021 19:38
@fengtao1998 @Jennifer88huang-zz
Update site2/docs/deploy-bare-metal.md
6a85ffb 
Co-authored-by: Jennifer Huang <47805623+Jennifer88huang@users.noreply.github.com>
@fengtao1998 @Jennifer88huang-zz
Update site2/docs/deploy-bare-metal.md
c1bbea2 
Co-authored-by: Jennifer Huang <47805623+Jennifer88huang@users.noreply.github.com>
@fengtao1998
Update deploy-bare-metal.md
c8c4ad3
sijia-w
sijia-w reviewed Aug 2, 2021
View reviewed changes
Comment thread site2/docs/deploy-bare-metal.md Outdated
sijia-w
sijia-w reviewed Aug 2, 2021
View reviewed changes
Comment thread site2/docs/deploy-bare-metal.md Outdated
sijia-w
sijia-w reviewed Aug 2, 2021
View reviewed changes
Comment thread site2/docs/deploy-bare-metal.md Outdated
sijia-w
sijia-w reviewed Aug 2, 2021
View reviewed changes
Comment thread site2/docs/deploy-bare-metal.md Outdated
sijia-w
sijia-w reviewed Aug 2, 2021
View reviewed changes
Comment thread site2/docs/deploy-bare-metal.md Outdated
sijia-w
sijia-w reviewed Aug 2, 2021
View reviewed changes
Comment thread site2/docs/deploy-bare-metal.md Outdated
sijia-w
sijia-w reviewed Aug 2, 2021
View reviewed changes
Comment thread site2/docs/deploy-bare-metal.md
sijia-w
sijia-w reviewed Aug 2, 2021
View reviewed changes
Comment thread site2/docs/deploy-bare-metal.md Outdated
sijia-w
sijia-w reviewed Aug 2, 2021
View reviewed changes
Comment thread site2/docs/deploy-bare-metal.md
sijia-w
sijia-w reviewed Aug 2, 2021
View reviewed changes
Comment thread site2/docs/deploy-bare-metal.md
sijia-w
sijia-w reviewed Aug 2, 2021
View reviewed changes
Comment thread site2/docs/deploy-bare-metal.md
sijia-w
sijia-w reviewed Aug 2, 2021
View reviewed changes
Comment thread site2/docs/deploy-bare-metal.md
sijia-w
sijia-w reviewed Aug 2, 2021
View reviewed changes
Comment thread site2/docs/deploy-bare-metal.md
sijia-w
sijia-w reviewed Aug 2, 2021
View reviewed changes
Comment thread site2/docs/deploy-bare-metal.md
sijia-w
sijia-w reviewed Aug 2, 2021
View reviewed changes
Comment thread site2/docs/deploy-bare-metal.md Outdated
sijia-w
sijia-w reviewed Aug 2, 2021
View reviewed changes
Comment thread site2/docs/deploy-bare-metal.md Outdated
sijia-w
sijia-w reviewed Aug 2, 2021
View reviewed changes
Comment thread site2/docs/deploy-bare-metal.md Outdated
sijia-w
sijia-w reviewed Aug 2, 2021
View reviewed changes
Comment thread site2/docs/deploy-bare-metal.md
fengtao1998 and others added 3 commits August 2, 2021 23:07
@fengtao1998 @sijia-w
Update site2/docs/deploy-bare-metal.md
8b2ae2b 
Co-authored-by: sijia-w <53718687+sijia-w@users.noreply.github.com>
@fengtao1998 @sijia-w
Update site2/docs/deploy-bare-metal.md
70ae7a5 
Co-authored-by: sijia-w <53718687+sijia-w@users.noreply.github.com>
@fengtao1998
Update deploy-bare-metal.md
5b25006 
pulsar->Pulsar
@fengtao1998 fengtao1998 removed their assignment Aug 5, 2021
fengtao1998 and others added 4 commits August 5, 2021 17:00
@fengtao1998 @sijia-w
Update site2/docs/deploy-bare-metal.md
2fb53d0 
Co-authored-by: sijia-w <53718687+sijia-w@users.noreply.github.com>
@fengtao1998 @sijia-w
Update site2/docs/deploy-bare-metal.md
eeb9263 
Co-authored-by: sijia-w <53718687+sijia-w@users.noreply.github.com>
@fengtao1998 @sijia-w
Update site2/docs/deploy-bare-metal.md
81d8539 
Co-authored-by: sijia-w <53718687+sijia-w@users.noreply.github.com>
@fengtao1998
Create deploy-bare-metal.md
6a0c151
@sijia-w

sijia-w commented Aug 5, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Looks good to me.

@fengtao1998

fengtao1998 commented Aug 9, 2021

Copy link
Copy Markdown
Contributor Author

@jennifer88huang PTAL

Jennifer88huang-zz
Jennifer88huang-zz reviewed Aug 9, 2021
View reviewed changes
Comment thread site2/docs/deploy-bare-metal.md Outdated
Jennifer88huang-zz
Jennifer88huang-zz approved these changes Aug 9, 2021
View reviewed changes
Comment thread site2/docs/deploy-bare-metal.md
Comment thread site2/docs/deploy-bare-metal.md Outdated
@Jennifer88huang-zz
Jennifer88huang-zz merged commit cdcb86b into apache:master Aug 10, 2021
bharanic-dev pushed a commit to bharanic-dev/pulsar that referenced this pull request Mar 18, 2022
@fengtao1998 @Jennifer88huang-zz
@sijia-w @splunk-xingw
[docs]Update deploy-bare-metal.md (apache#11452)
aa3bdd7 
* Update deploy-bare-metal.md

* Update deploy-bare-metal.md

* Create deploy-bare-metal.md

* Update deploy-bare-metal.md

* Update deploy-bare-metal.md

* Update site2/docs/deploy-bare-metal.md

Co-authored-by: Jennifer Huang <47805623+Jennifer88huang@users.noreply.github.com>

* Update site2/docs/deploy-bare-metal.md

Co-authored-by: Jennifer Huang <47805623+Jennifer88huang@users.noreply.github.com>

* Update deploy-bare-metal.md

* Update site2/docs/deploy-bare-metal.md

Co-authored-by: sijia-w <53718687+sijia-w@users.noreply.github.com>

* Update site2/docs/deploy-bare-metal.md

Co-authored-by: sijia-w <53718687+sijia-w@users.noreply.github.com>

* Update deploy-bare-metal.md

pulsar->Pulsar

* Update site2/docs/deploy-bare-metal.md

Co-authored-by: sijia-w <53718687+sijia-w@users.noreply.github.com>

* Update site2/docs/deploy-bare-metal.md

Co-authored-by: sijia-w <53718687+sijia-w@users.noreply.github.com>

* Update site2/docs/deploy-bare-metal.md

Co-authored-by: sijia-w <53718687+sijia-w@users.noreply.github.com>

* Create deploy-bare-metal.md

* Update site2/docs/deploy-bare-metal.md

* Update site2/docs/deploy-bare-metal.md

Co-authored-by: Jennifer Huang <47805623+Jennifer88huang@users.noreply.github.com>
Co-authored-by: sijia-w <53718687+sijia-w@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@murong00 murong00 murong00 approved these changes
+2 more reviewers
@sijia-w sijia-w sijia-w left review comments
@Jennifer88huang-zz Jennifer88huang-zz Jennifer88huang-zz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@fengtao1998 fengtao1998

Labels

doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.

Projects

None yet

Milestone

2.9.0

Development

Successfully merging this pull request may close these issues.

4 participants

@fengtao1998 @Jennifer88huang-zz @sijia-w @murong00