Add metrics for writing or reading size of cursor#11500
Merged
Conversation
Technoboy-
added a commit
to Technoboy-/pulsar
that referenced
this pull request
Jul 29, 2021
Technoboy-
force-pushed
the
add-metrics-2
branch
from
July 29, 2021 15:32
8c3253e to
445f8f8
Compare
codelipenghui
approved these changes
Jul 29, 2021
codelipenghui
added
release/2.8.1
type/enhancement
Contributor
Author
|
@codelipenghui : |
Anonymitaet
reviewed
Jul 30, 2021
Anonymitaet
added
the
doc
codelipenghui
approved these changes
Aug 3, 2021
codelipenghui
requested review from
315157973,
eolivelli,
gaoran10,
hangc0276,
merlimat and
sijie
August 3, 2021 01:27
Anonymitaet
approved these changes
Aug 3, 2021
Anonymitaet
left a comment
Anonymitaet
left a comment
Member
There was a problem hiding this comment.
Thanks for your contribution. Approved from the language perspective.
Contributor
Author
|
/pulsarbot run-failure-checks |
hangc0276
approved these changes
Aug 5, 2021
Technoboy-
added a commit
to Technoboy-/pulsar
that referenced
this pull request
Aug 6, 2021
Technoboy-
force-pushed
the
add-metrics-2
branch
from
August 6, 2021 08:20
68730b2 to
5b6fed9
Compare
Technoboy-
added a commit
to Technoboy-/pulsar
that referenced
this pull request
Aug 6, 2021
Technoboy-
force-pushed
the
add-metrics-2
branch
from
August 6, 2021 10:03
a4f991d to
d68e3b5
Compare
michaeljmarshall
requested changes
Aug 7, 2021
michaeljmarshall
left a comment
michaeljmarshall
left a comment
Member
There was a problem hiding this comment.
I think we might need to remove the single dimension metrics for namespace. See comments for details.
Otherwise, the new metrics look good to me.
Technoboy-
force-pushed
the
add-metrics-2
branch
from
August 9, 2021 02:48
d68e3b5 to
105ae9c
Compare
Contributor
Author
Thanks and I have updated the patch. |
Contributor
|
@michaeljmarshall Please help review again. |
michaeljmarshall
approved these changes
Aug 9, 2021
michaeljmarshall
left a comment
michaeljmarshall
left a comment
Member
There was a problem hiding this comment.
Looks good. Minor comment about updating a Javadoc.
Technoboy-
force-pushed
the
add-metrics-2
branch
from
August 10, 2021 01:05
664539d to
776820a
Compare
hangc0276
pushed a commit
that referenced
this pull request
Aug 12, 2021
### Motivation Currently, there is no visibility about the following activities: - How many bytes are written from a cursor update? - How many bytes are read from loading a cursor? So when the bookkeeper cluster is having heavy traffic, it is hard to tell which topic or namespace contributes most of the traffic. Add metrics at the broker about how many bytes are written and read per cursor/namespace. ### Modifications Add metrics `writeLedgerSize`, `writeLedgerLogicalSize`, `readLedgerSize`. (cherry picked from commit bfae8f6)
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
### Motivation Currently, there is no visibility about the following activities: - How many bytes are written from a cursor update? - How many bytes are read from loading a cursor? So when the bookkeeper cluster is having heavy traffic, it is hard to tell which topic or namespace contributes most of the traffic. Add metrics at the broker about how many bytes are written and read per cursor/namespace. ### Modifications Add metrics `writeLedgerSize`, `writeLedgerLogicalSize`, `readLedgerSize`.
momo-jun
added a commit
to momo-jun/pulsar
that referenced
this pull request
Aug 5, 2022
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, there is no visibility about the following activities:
So when the bookkeeper cluster is having heavy traffic, it is hard to tell which topic or namespace contributes most of the traffic.
Add metrics at the broker about how many bytes are written and read per cursor/namespace.
Modifications
Add metrics
writeLedgerSize,writeLedgerLogicalSize,readLedgerSize.