[ManagedLedger] Make 'StatsPeroidSeconds' configurable#11584
Merged
codelipenghui merged 2 commits intoAug 9, 2021
Merged
Conversation
Technoboy-
added a commit
to Technoboy-/pulsar
that referenced
this pull request
Aug 6, 2021
Technoboy-
force-pushed
the
make-stats-period-seconds-configurable
branch
from
August 6, 2021 09:19
1e79cee to
a6e06c3
Compare
Technoboy-
force-pushed
the
make-stats-period-seconds-configurable
branch
from
August 6, 2021 09:20
a6e06c3 to
f984f2a
Compare
Technoboy-
changed the title
codelipenghui
approved these changes
Aug 7, 2021
codelipenghui
added
the
type/enhancement
hangc0276
approved these changes
Aug 7, 2021
eolivelli
requested changes
Aug 7, 2021
eolivelli
left a comment
eolivelli
left a comment
Contributor
There was a problem hiding this comment.
Overall is good
I left one comment PTAL
Contributor
|
In which case, we should change the metric stats refresh frequency? |
Contributor
Author
|
/pulsarbot run-failure-checks |
LeBW
pushed a commit
to LeBW/pulsar
that referenced
this pull request
Aug 9, 2021
### Motivation Make `StatsPeroidSeconds` configurable. ### Modifications - Move ‘StatsPeriodSeconds’ from ManagedLedgerFactoryImpl to ManagedLedgerFactoryConfig. - Add config `managedLedgerStatsPeriodSeconds`.
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
### Motivation Make `StatsPeroidSeconds` configurable. ### Modifications - Move ‘StatsPeriodSeconds’ from ManagedLedgerFactoryImpl to ManagedLedgerFactoryConfig. - Add config `managedLedgerStatsPeriodSeconds`.
dlg99
pushed a commit
to dlg99/pulsar
that referenced
this pull request
May 11, 2022
Make `StatsPeroidSeconds` configurable. - Move ‘StatsPeriodSeconds’ from ManagedLedgerFactoryImpl to ManagedLedgerFactoryConfig. - Add config `managedLedgerStatsPeriodSeconds`. (cherry picked from commit ddeae65)
dlg99
pushed a commit
to dlg99/pulsar
that referenced
this pull request
May 11, 2022
Make `StatsPeroidSeconds` configurable. - Move ‘StatsPeriodSeconds’ from ManagedLedgerFactoryImpl to ManagedLedgerFactoryConfig. - Add config `managedLedgerStatsPeriodSeconds`.
dlg99
pushed a commit
to dlg99/pulsar
that referenced
this pull request
May 12, 2022
Make `StatsPeroidSeconds` configurable. - Move ‘StatsPeriodSeconds’ from ManagedLedgerFactoryImpl to ManagedLedgerFactoryConfig. - Add config `managedLedgerStatsPeriodSeconds`. (cherry picked from commit ddeae65)
dlg99
pushed a commit
to dlg99/pulsar
that referenced
this pull request
May 12, 2022
Make `StatsPeroidSeconds` configurable. - Move ‘StatsPeriodSeconds’ from ManagedLedgerFactoryImpl to ManagedLedgerFactoryConfig. - Add config `managedLedgerStatsPeriodSeconds`.
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 12, 2022
* [ManagedLedger] Make 'StatsPeroidSeconds' configurable (apache#11584) Make `StatsPeroidSeconds` configurable. - Move ‘StatsPeriodSeconds’ from ManagedLedgerFactoryImpl to ManagedLedgerFactoryConfig. - Add config `managedLedgerStatsPeriodSeconds`. * Offloader metrics (apache#13833) Currently, there is no offload metrics for tiered storage, so it is very hard for us to debug the performance issues. For example , we can not find why offload is slow or why read offload is slow. For above reasons. we need to add some offload metrics for monitoring. Add metrics during offload procedure and read offload data procedure. Including offloadTime, offloadError, offloadRate, readLedgerLatency, writeStoreLatency, writeStoreError, readOffloadIndexLatency, readOffloadDataLatency, readOffloadRate, readOffloadError. (cherry picked from commit 732049f) Co-authored-by: GuoJiwei <technoboy@apache.org> Co-authored-by: Tao Jiuming <95597048+tjiuming@users.noreply.github.com>
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 12, 2022
* [ManagedLedger] Make 'StatsPeroidSeconds' configurable (apache#11584) Make `StatsPeroidSeconds` configurable. - Move ‘StatsPeriodSeconds’ from ManagedLedgerFactoryImpl to ManagedLedgerFactoryConfig. - Add config `managedLedgerStatsPeriodSeconds`. (cherry picked from commit ddeae65) * Offloader metrics (apache#13833) Currently, there is no offload metrics for tiered storage, so it is very hard for us to debug the performance issues. For example , we can not find why offload is slow or why read offload is slow. For above reasons. we need to add some offload metrics for monitoring. Add metrics during offload procedure and read offload data procedure. Including offloadTime, offloadError, offloadRate, readLedgerLatency, writeStoreLatency, writeStoreError, readOffloadIndexLatency, readOffloadDataLatency, readOffloadRate, readOffloadError. (cherry picked from commit 732049f) Co-authored-by: GuoJiwei <technoboy@apache.org> Co-authored-by: Tao Jiuming <95597048+tjiuming@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Make
StatsPeroidSecondsconfigurable.Modifications
managedLedgerStatsPeriodSeconds.###Documentation
I think it's no need to update doc.