[Enhancement] avoid duplicate deletion of schema#11640
Conversation
|
I believe that this is a good idea. Can you please add a test case ? |
|
Nice catch! |
hangc0276
added
release/2.8.2
type/enhancement
|
@hangc0276 thanks for triaging PR and issues. When you label PRs, if you find some PRs do not need to update doc, could you please help label the PR with |
@Anonymitaet Ok, I will add doc label in the following PRs, thank you! |
eolivelli
left a comment
eolivelli
left a comment
There was a problem hiding this comment.
Good work
Can you add a test case?
Sorry for the late reply! I will add a test later. |
|
/pulsarbot run-failure-checks |
2 similar comments
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
…_duplicate_deletion_of_schema
|
/pulsarbot run-failure-checks |
|
@eolivelli @hangc0276 Sorry for the late. I supplemented a test case. PTAL~ |
| final String exNp = "persistent://" + exNs + "/np"; | ||
| admin.topics().createNonPartitionedTopic(exNp); | ||
| // insert an invalid topic name | ||
| pulsar.getLocalMetadataStore().put( |
There was a problem hiding this comment.
why this is related to this patch ?
There was a problem hiding this comment.
There are actually three scenarios I tested for partitioned topics, non-partitioned topics and exceptions while handling internal deletion.
| } | ||
| } | ||
|
|
||
| log.info("Successfully send deletion command of partitioned-topics:{} " |
There was a problem hiding this comment.
It should be a debug level log? If we have many partitioned topics and non-partitioned-topics, we will get a very long log here, maybe print the topic count is better?
There was a problem hiding this comment.
Thanks for your suggestion! I have addressed the comment. PTAL~ @codelipenghui
### Motivation Currently when I need to delete a namespace forcedly, the `NamespacesBase#internalDeleteNamespaceForcefully` will firstly list all the topics under the namespace and then delete them concurrently without distinguishing wheather the topic is partitioned or non-partitioned. This behaivor will cause duplicate deletion of schema when the topic list contains partitioned topics, because all the partitions of the partitioned topic share the same schema. (cherry picked from commit e28f69e)
### Motivation Currently when I need to delete a namespace forcedly, the `NamespacesBase#internalDeleteNamespaceForcefully` will firstly list all the topics under the namespace and then delete them concurrently without distinguishing wheather the topic is partitioned or non-partitioned. This behaivor will cause duplicate deletion of schema when the topic list contains partitioned topics, because all the partitions of the partitioned topic share the same schema.
5 participants
Motivation
Currently when I need to delete a namespace forcedly, the
NamespacesBase#internalDeleteNamespaceForcefullywill firstly list all the topics under the namespace and then delete them concurrently without distinguishing wheather the topic is partitioned or non-partitioned. This behaivor will cause duplicate deletion of schema when the topic list contains partitioned topics, because all the partitions of the partitioned topic share the same schema.Modifications
Distinguish partitioned topic to avoid duplicate deletion of the same schema.
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
This PR does not need to update the docs.