[pulsar-admin] allow create functions with package URL - #11666
Merged
sijie merged 7 commits intoAug 17, 2021
Merged
Conversation
freeznet
requested review from
codelipenghui,
sijie,
tuteng,
wolfstudy and
zymap
August 13, 2021 09:37
freeznet
added
doc-required
freeznet
changed the title
freeznet
changed the title
Member
|
@freeznet thanks for your contribution! When can we start updating docs? |
Contributor
Author
|
@Anonymitaet thanks, we can start the doc once this PR is merged. |
zymap
approved these changes
Aug 16, 2021
eolivelli
requested changes
Aug 16, 2021
eolivelli
left a comment
eolivelli
left a comment
Contributor
There was a problem hiding this comment.
overall looks good
please take a look to my comment about reducing duplicated code
Member
@freeznet please ping me if you submit a doc PR, thanks |
sijie
approved these changes
Aug 17, 2021
codelipenghui
pushed a commit
that referenced
this pull request
Aug 19, 2021
4 tasks
1 task
Anonymitaet
removed
the
doc-required
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
Fix apache#11665 ### Motivation Allow user to create function with package URL with pulsar-admin. ### Modifications - allow passing valid package URL from pulsar-admin functions - added tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #11665
Motivation
Allow user to create function with package URL with pulsar-admin.
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
For contributor
For this PR, do we need to update docs?
If yes, please update docs or create a follow-up issue if you need help.
If no, please explain why.
For committer
For this PR, do we need to update docs?
If yes,
if you update docs in this PR, label this PR with the
doclabel.if you plan to update docs later, label this PR with the
doc-requiredlabel.if you need help on updating docs, create a follow-up issue with the
doc-requiredlabel.If no, label this PR with the
no-need-doclabel and explain why.