Proxy forward auth data - #1169
Conversation
jai1
added
the
type/enhancement
…into ProxyForwardAuthData
…into ProxyForwardAuthData
saandrews
left a comment
saandrews
left a comment
There was a problem hiding this comment.
Overall looks ok, few comments.
| private final int MaxNonPersistentPendingMessages; | ||
| private String originalPrincipal = null; | ||
|
|
||
| private Set<String> proxyRoles = Sets.newHashSet(); |
There was a problem hiding this comment.
If it's initialized in constructor, why create a new set here?
| ctx.close(); | ||
| } | ||
|
|
||
| private boolean validateOriginalPrincipal(String originalPrincipal, ByteBuf errorResponse, String topicName, |
There was a problem hiding this comment.
Can you add comment explaining the logic?
| connect.hasOriginalAuthData() ? connect.getOriginalAuthData() : null, | ||
| connect.hasOriginalAuthMethod() ? connect.getOriginalAuthMethod() : null, | ||
| connect.hasOriginalPrincipal() ? connect.getOriginalPrincipal() : null, | ||
| sslSession); |
There was a problem hiding this comment.
What happens if sslSession is null ?
There was a problem hiding this comment.
is sslSession is null AuthDataCommand.hasDataFromTls will return false
|
|
||
| // Original auth role and auth Method that was passed | ||
| // to the proxy. In this case the auth info above | ||
| // will the the auth of the proxy itself |
There was a problem hiding this comment.
"will be the"?
Same for the remaining comments as well.
|
@saandrews - have addressed your comments |
|
retest this please |
|
|
||
| // If this flag is set then the broker authenticates the original Auth data | ||
| // else it just accepts the originalPrincipal and authorizes it (if required). | ||
| private boolean authenticateOriginalAuthData = false; |
There was a problem hiding this comment.
Config options need to be also added into conf/broker.conf and conf/standalone.conf, also check if there is a suitable name prefix this can be aggregated into.
| if (lookupSemaphore.tryAcquire()) { | ||
| final String originalPrincipal = lookup.hasOriginalPrincipal() ? lookup.getOriginalPrincipal() | ||
| : this.originalPrincipal; | ||
| String originalPrincipal; |
There was a problem hiding this comment.
This check can be done before acquiring the semaphore
There was a problem hiding this comment.
As with similar changes, try to put common logic in a single method
|
|
||
| // Forward client authData to Broker for re authorization | ||
| // make sure authentication is enabled for this to take effect | ||
| private boolean forwardAuthData = false; |
There was a problem hiding this comment.
Should be added to proxy.conf
There was a problem hiding this comment.
Rename to something like authorizationForwardCredentials or similar
|
@merlimat @rdhabalia @saandrews - can I merge this or do you want to take one last look. |
| lookup); | ||
|
|
||
| if (authenticateOriginalAuthData && lookup.hasOriginalAuthData() && originalPrincipal == null) { | ||
| return; |
There was a problem hiding this comment.
this condition seems little tricky. if we fail to validate original principal then validateOriginalPrincipal() will send failure response to the client and then thread should not process anything further. but then with this condition there is a possibility to move forward and thread will do further processing if authenticateOriginalAuthData && lookup.hasOriginalAuthData() =is false.??
|
@rdhabalia - handled your comments - hope to get a +1 from you |
4 participants
======
Currently the proxy extracts and forwards the client Principal to the broker. Client Principal is a modifiable string i.e can be changed or manufactured by the Proxy.
What we want to do instead is to send the clientAuthData to the broker - which is in most cases digitally signed. The broker will extract the client principal from the clientAuthData and reauthenticate the client.
In order to enforce this behavior we have introduced two new flags:-
======
@msb-at-yahoo