[package management service] fix wrappedBuffer always using the same block of memory - #11782
Merged
codelipenghui merged 2 commits intoAug 26, 2021
Conversation
wrappedBuffer always having the same block of memory wrappedBuffer always using the same block of memory
zymap
reviewed
Aug 26, 2021
codelipenghui
approved these changes
Aug 26, 2021
hangc0276
approved these changes
Aug 26, 2021
Member
|
Good catch @freeznet ! I also added "release/2.7.4" since this looks like an important fix. |
Member
|
or does it only apply to 2.8.x + ? I see that the change was made to DLOutputStream, but I guess that's not used asynchronously by Pulsar Functions upload, so that wouldn't be impacted? |
Contributor
Author
|
@lhotari thanks for asking. from my understanding this fix only applies to package management service, and not with Pulsar Functions upload, so it might not affect release 2.7.x |
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
…e block of memory (apache#11782)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11781
Motivation
When uploading file content to bk, the
BookKeeperPackagesStoragealways use the same block of memory to read the file content and build up a bunch of zero-copyByteBuf.This causes the
ByteBufs having the same block of memory and break the file content.Modifications
Alloc new memory block in each iteration.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
For contributor
For this PR, do we need to update docs?
If yes, please update docs or create a follow-up issue if you need help.
If no, please explain why.
For committer
For this PR, do we need to update docs?
If yes,
if you update docs in this PR, label this PR with the
doclabel.if you plan to update docs later, label this PR with the
doc-requiredlabel.if you need help on updating docs, create a follow-up issue with the
doc-requiredlabel.If no, label this PR with the
no-need-doclabel and explain why.internal bug fix