[Client] Set key in message metadata for batch message built with KEY_BASED batch builder - #11816
Closed
lhotari wants to merge 1 commit into
Closed
[Client] Set key in message metadata for batch message built with KEY_BASED batch builder#11816lhotari wants to merge 1 commit into
lhotari wants to merge 1 commit into
Conversation
Member
Author
|
This needs tests. |
Member
Author
|
@codelipenghui it looks like the required code to set orderingKey and partitionKey for the batch message got removed in PR #7416 . Was that an intentional change? |
…tch builder - restore logic that was removed in apache#7416
lhotari
force-pushed
the
lh-set-key-metadata-for-batchmessage
branch
from
August 27, 2021 09:13
36c0f95 to
8f7646d
Compare
lhotari
marked this pull request as ready for review
August 27, 2021 09:15
Member
Author
|
actually it seems that this PR is invalid since the logic was just moved to another location in code by #7416 . I'll close this PR as invalid. I guess there would have to be some integration tests to verify the KEY_BASED batch builder issues that I'm trying to investigate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The
BatcherBuilder.KEY_BASEDdoesn't seem to work withKEY_SHAREDconsumers.When looking at the code, it can be seen that the message metadata for the batch message doesn't contain keying metadata that KEY_SHARED consumers use for selecting messages.
Modifications