[docs] Update compaction metrics in 282 - #11896
Merged
Merged
Conversation
Contributor
Author
|
@Technoboy- @Anonymitaet Please help review the changes and leave a comment if anything should be modified. Thank you. |
Anonymitaet
reviewed
Sep 3, 2021
Anonymitaet
left a comment
Anonymitaet
left a comment
Member
There was a problem hiding this comment.
This PR modifies docs for master. Will you modify docs for 2.8.2?
| | pulsar_compaction_duration_time_in_mills | Gauge | The duration time of compaction | | ||
| | pulsar_compaction_read_throughput | Gauge | The read throughput of compaction | | ||
| | pulsar_compaction_write_throughput | Gauge | The write throughput of compaction | | ||
| | pulsar_in_bytes_total | Counter | The total number of messages in bytes received for this topic. | |
Member
There was a problem hiding this comment.
Suggested change
| | pulsar_in_bytes_total | Counter | The total number of messages in bytes received for this topic. | | |
| | pulsar_in_bytes_total | Counter | The total number of messages received for this topic (in bytes). | |
if agree, please update all, thanks
Anonymitaet
added
the
doc
Contributor
Author
|
@Anonymitaet I prefer to not use the parenthesis, that way, "in bytes" looks like a note. The main info in this sentence is still "the total number of messages". |
Contributor
Author
|
@Anonymitaet I modified the doc in 2.8.2, and then I updated the changes to master. So this pr covers changes to both versions. |
Anonymitaet
approved these changes
Sep 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up of #11739.