Skip to content

Avoid adding duplicated BrokerEntryMetadata #12018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BewareMyPower merged 2 commits into from
Sep 18, 2021
Merged

Avoid adding duplicated BrokerEntryMetadata #12018

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9d7e8d
Avoid adding duplicated BrokerEntryMetadata
BewareMyPower Sep 13, 2021
25eea40
Call beforeAddEntry at the beginning of internalAsyncAddEntry
BewareMyPower Sep 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -717,6 +717,9 @@ public void asyncAddEntry(ByteBuf buffer, int numberOfMessages, AddEntryCallback
}

private synchronized void internalAsyncAddEntry(OpAddEntry addOperation) {
if (!beforeAddEntry(addOperation)) {
return;
}
pendingAddEntries.add(addOperation);
final State state = STATE_UPDATER.get(this);
if (state == State.Fenced) {
Expand Down Expand Up @@ -779,10 +782,7 @@ private synchronized void internalAsyncAddEntry(OpAddEntry addOperation) {
addOperation.setCloseWhenDone(true);
STATE_UPDATER.set(this, State.ClosingLedger);
}
// interceptor entry before add to bookie
if (beforeAddEntry(addOperation)) {
addOperation.initiate();
}
addOperation.initiate();
}
}

Expand Down Expand Up @@ -1513,9 +1513,7 @@ public synchronized void updateLedgersIdsComplete(Stat stat) {
ReferenceCountUtil.release(existsOp.data);
}
existsOp.setLedger(currentLedger);
if (beforeAddEntry(existsOp)) {
pendingAddEntries.add(existsOp);
}
pendingAddEntries.add(existsOp);
}
} while (existsOp != null && --pendingSize > 0);

Expand Down