Future completed twice in the method of impl.MLPendingAckStore#closeAsync

[lordcheng10]

CompletableFuture is completed twice in this code：

pulsar/pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/pendingack/impl/MLPendingAckStore.java

Lines 120 to 135 in 0460472

	cursor.asyncClose(new AsyncCallbacks.CloseCallback() {
	@Override
	public void closeComplete(Object ctx) {
	try {
	managedLedger.close();
	} catch (Exception e) {
	completableFuture.completeExceptionally(e);
	}
	completableFuture.complete(null);
	}
	@Override
	public void closeFailed(ManagedLedgerException exception, Object ctx) {
	completableFuture.completeExceptionally(exception);
	}
	}, null);

[lordcheng10]

@congbobo184 As you mentioned in #12113 (comment), I fixed it here

[congbobo184]

@lordcheng10 could you please change managedLedger.close to managedLedger.closeAsync and add some log for it. thanks.

[lordcheng10]

@lordcheng10 could you please change managedLedger.close to managedLedger.closeAsync and add some log for it. thanks.

Ok, will fix!

[lordcheng10]

@lordcheng10 could you please change managedLedger.close to managedLedger.closeAsync and add some log for it. thanks.

please review again. thanks. @congbobo184

[lordcheng10]

/pulsarbot run-failure-checks

[lordcheng10]

/pulsarbot run-failure-checks

[congbobo184]

LGTM!

[lordcheng10]

/pulsarbot run-failure-checks

[lordcheng10]

/pulsarbot run-failure-checks

[lordcheng10]

/pulsarbot run-failure-checks

[lordcheng10]

/pulsarbot run-failure-checks

[lordcheng10]

/pulsarbot run-failure-checks

[Anonymitaet]

@lordcheng10 Thanks for your contribution. For this PR, do we need to update docs?

(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

[lordcheng10]

@lordcheng10 Thanks for your contribution. For this PR, do we need to update docs?

(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

I think there is no need to modify the document, this PR did not change the original logic.

[lordcheng10]

@merlimat PTAL,thanks!

[eolivelli]

+1

[lhotari]

Good work @lordcheng10 . It seems that this fix also has a performance improvement aspect since it replaces a blocking close method with closeAsync. Nice.