Flaky Tests: AdminApiSchemaTest#testSchemaInfoApi - #12461
Merged
merlimat merged 1 commit intoNov 11, 2021
Conversation
Contributor
Author
|
@eolivelli @lhotari @merlimat PTAL |
eolivelli
requested review from
codelipenghui,
congbobo184,
gaoran10,
lhotari and
merlimat
October 26, 2021 12:41
Contributor
Author
|
@lhotari @codelipenghui PTAL |
merlimat
approved these changes
Nov 11, 2021
eolivelli
pushed a commit
to eolivelli/pulsar
that referenced
this pull request
Nov 29, 2021
nicoloboschi
added a commit
to datastax/pulsar
that referenced
this pull request
Jan 31, 2022
(cherry picked from commit b533fe5)
1 task
michaeljmarshall
pushed a commit
that referenced
this pull request
Mar 7, 2022
* [flaky-tests] AdminApiSchemaTest#testSchemaInfoApi * use custom json schema * remove old comment ### Motivation This is the same fix applied here #12461. The problem with the other pull is that the `AbstractSchema#clone()` method does return the same instance, so the fix is not useful at all. I see this test also failing in 2.8 and 2.9 branch, I recommend to cherry-pick it. ### Modifications * Create a new INT schema for the test purpose - [x] `no-need-doc`
michaeljmarshall
pushed a commit
that referenced
this pull request
Mar 7, 2022
(cherry picked from commit b533fe5)
michaeljmarshall
pushed a commit
that referenced
this pull request
Mar 7, 2022
* [flaky-tests] AdminApiSchemaTest#testSchemaInfoApi * use custom json schema * remove old comment ### Motivation This is the same fix applied here #12461. The problem with the other pull is that the `AbstractSchema#clone()` method does return the same instance, so the fix is not useful at all. I see this test also failing in 2.8 and 2.9 branch, I recommend to cherry-pick it. ### Modifications * Create a new INT schema for the test purpose - [x] `no-need-doc` (cherry picked from commit 32c3cd1)
michaeljmarshall
pushed a commit
that referenced
this pull request
Mar 7, 2022
* [flaky-tests] AdminApiSchemaTest#testSchemaInfoApi * use custom json schema * remove old comment ### Motivation This is the same fix applied here #12461. The problem with the other pull is that the `AbstractSchema#clone()` method does return the same instance, so the fix is not useful at all. I see this test also failing in 2.8 and 2.9 branch, I recommend to cherry-pick it. ### Modifications * Create a new INT schema for the test purpose - [x] `no-need-doc` (cherry picked from commit 32c3cd1)
michaeljmarshall
pushed a commit
that referenced
this pull request
Mar 7, 2022
(cherry picked from commit b533fe5)
michaeljmarshall
pushed a commit
that referenced
this pull request
Mar 7, 2022
* [flaky-tests] AdminApiSchemaTest#testSchemaInfoApi * use custom json schema * remove old comment ### Motivation This is the same fix applied here #12461. The problem with the other pull is that the `AbstractSchema#clone()` method does return the same instance, so the fix is not useful at all. I see this test also failing in 2.8 and 2.9 branch, I recommend to cherry-pick it. ### Modifications * Create a new INT schema for the test purpose - [x] `no-need-doc` (cherry picked from commit 32c3cd1)
nicoloboschi
added a commit
to datastax/pulsar
that referenced
this pull request
Mar 7, 2022
* [flaky-tests] AdminApiSchemaTest#testSchemaInfoApi * use custom json schema * remove old comment ### Motivation This is the same fix applied here apache#12461. The problem with the other pull is that the `AbstractSchema#clone()` method does return the same instance, so the fix is not useful at all. I see this test also failing in 2.8 and 2.9 branch, I recommend to cherry-pick it. ### Modifications * Create a new INT schema for the test purpose - [x] `no-need-doc` (cherry picked from commit 32c3cd1) (cherry picked from commit 0f72a4f)
nicoloboschi
added a commit
to datastax/pulsar
that referenced
this pull request
Mar 7, 2022
* [flaky-tests] AdminApiSchemaTest#testSchemaInfoApi * use custom json schema * remove old comment ### Motivation This is the same fix applied here apache#12461. The problem with the other pull is that the `AbstractSchema#clone()` method does return the same instance, so the fix is not useful at all. I see this test also failing in 2.8 and 2.9 branch, I recommend to cherry-pick it. ### Modifications * Create a new INT schema for the test purpose - [x] `no-need-doc` (cherry picked from commit 32c3cd1) (cherry picked from commit 0f72a4f)
gaozhangmin
pushed a commit
to gaozhangmin/pulsar
that referenced
this pull request
Mar 8, 2022
* [flaky-tests] AdminApiSchemaTest#testSchemaInfoApi * use custom json schema * remove old comment ### Motivation This is the same fix applied here apache#12461. The problem with the other pull is that the `AbstractSchema#clone()` method does return the same instance, so the fix is not useful at all. I see this test also failing in 2.8 and 2.9 branch, I recommend to cherry-pick it. ### Modifications * Create a new INT schema for the test purpose - [x] `no-need-doc`
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
* [flaky-tests] AdminApiSchemaTest#testSchemaInfoApi * use custom json schema * remove old comment ### Motivation This is the same fix applied here apache#12461. The problem with the other pull is that the `AbstractSchema#clone()` method does return the same instance, so the fix is not useful at all. I see this test also failing in 2.8 and 2.9 branch, I recommend to cherry-pick it. ### Modifications * Create a new INT schema for the test purpose - [x] `no-need-doc`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
I see
AdminApiSchemaTest#testSchemaInfoApifailing in this way:It only fails with INT32 default shema.
I found another test (
SchemaTest#testNullKeyValueProperty) which sets a null-key property to INT32 instance; so if it runs before, it makes AdminApiSchemaTest#testSchemaInfoApi fail.Modifications
Changed the
SchemaTest#testNullKeyValuePropertytest in order to leave the default INT32 implementation unchanged.Alternatively, I could made the
propertiesfield final, at least for defaultsSchemaInfos but this would result in a breaking change.This change is a trivial rework / code cleanup without any test coverage.
Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
no-need-doc