Skip to content

Add error log when new jetty client exception #12840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codelipenghui merged 1 commit into from
Nov 18, 2021
Merged

Add error log when new jetty client exception #12840

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/AdminProxyHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ protected HttpClient newHttpClient() {

if (config.isTlsEnabledWithBroker()) {
try {
X509Certificate trustCertificates[] = SecurityUtility
X509Certificate[] trustCertificates = SecurityUtility
.loadCertificatesFromPemFile(config.getBrokerClientTrustCertsFilePath());

SSLContext sslCtx;
Expand All @@ -281,6 +281,7 @@ protected HttpClient newHttpClient() {

return new JettyHttpClient(contextFactory);
} catch (Exception e) {
LOG.error("new jetty http client exception ", e);
try {
auth.close();
} catch (IOException ioe) {
Expand All @@ -303,7 +304,7 @@ protected String rewriteTarget(HttpServletRequest request) {

boolean isFunctionsRestRequest = false;
String requestUri = request.getRequestURI();
for (String routePrefix: functionRoutes) {
for (String routePrefix : functionRoutes) {
if (requestUri.startsWith(routePrefix)) {
isFunctionsRestRequest = true;
break;
Expand All @@ -324,7 +325,7 @@ protected String rewriteTarget(HttpServletRequest request) {

if (LOG.isDebugEnabled()) {
LOG.debug("[{}:{}] Selected active broker is {}", request.getRemoteAddr(), request.getRemotePort(),
url.toString());
url);
}
} catch (Exception e) {
LOG.warn("[{}:{}] Failed to get next active broker {}", request.getRemoteAddr(),
Expand Down