Skip to content

[Java Client] Make userProvidedProducerName final #12849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eolivelli merged 1 commit into from
Nov 17, 2021
Merged

[Java Client] Make userProvidedProducerName final #12849

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ public class ProducerImpl<T> extends ProducerBase<T> implements TimerTask, Conne

// Globally unique producer name
private String producerName;
private boolean userProvidedProducerName = false;
private final boolean userProvidedProducerName;

private String connectionId;
private String connectedSince;
Expand Down Expand Up @@ -161,9 +161,7 @@ public ProducerImpl(PulsarClientImpl client, String topic, ProducerConfiguration
super(client, topic, conf, producerCreatedFuture, schema, interceptors);
this.producerId = client.newProducerId();
this.producerName = conf.getProducerName();
if (StringUtils.isNotBlank(producerName)) {
this.userProvidedProducerName = true;
}
this.userProvidedProducerName = StringUtils.isNotBlank(producerName);
this.partitionIndex = partitionIndex;
this.pendingMessages = createPendingMessagesQueue();
if (conf.getMaxPendingMessages() > 0) {
Expand Down