Remove unneeded ZK operations for setting watches#12866
Merged
Conversation
merlimat
added
the
type/enhancement
merlimat
requested review from
codelipenghui,
eolivelli,
hangc0276 and
rdhabalia
November 18, 2021 02:02
|
@merlimat:Thanks for your contribution. For this PR, do we need to update docs? |
merlimat
added
doc-not-needed
Jason918
approved these changes
Nov 18, 2021
codelipenghui
approved these changes
Nov 19, 2021
dlg99
pushed a commit
to dlg99/pulsar
that referenced
this pull request
Nov 23, 2021
eolivelli
pushed a commit
to eolivelli/pulsar
that referenced
this pull request
Nov 29, 2021
fxbing
pushed a commit
to fxbing/pulsar
that referenced
this pull request
Dec 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
After the change to use ZK persistent watches (#11198), we don't need anymore to perform followup
getData()orexists()calls after aNONODEerror, with the purpose of setting a watch on the non-existing z-node.With persistent watches, we're going to get the watch notification in any case.