Skip to content

Fix running pulsar-perf in docker image after #11285 changes - #13022

Closed
lhotari wants to merge 1 commit into
apache:masterfrom
lhotari:lh-fix-broker-pulsar-perf-in-docker-image
Closed

Fix running pulsar-perf in docker image after #11285 changes#13022
lhotari wants to merge 1 commit into
apache:masterfrom
lhotari:lh-fix-broker-pulsar-perf-in-docker-image

Conversation

@lhotari

@lhotari lhotari commented Nov 29, 2021

Copy link
Copy Markdown
Member

Motivation

Running pulsar-perf in docker fails with this error:

root@3b36a0ea475b:/pulsar# ./bin/pulsar-perf produce 
[0.000s][error][logging] Error opening log file 'logs/pulsar_gc_14.log': No such file or directory
[0.000s][error][logging] Initialization of output 'file=logs/pulsar_gc_%p.log' using options 'filecount=10,filesize=20M' failed.
Invalid -Xlog option '-Xlog:gc*:logs/pulsar_gc_%p.log:time,uptime:filecount=10,filesize=20M', see error log for details.
Error: Could not create the Java Virtual Machine.
Error: A fatal exception has occurred. Program will exit.

Modifications

- create /pulsar/logs directory since it's now required for
  running pulsar-perf after apache#11285 changes
@lhotari lhotari added type/bug The PR fixed a bug or issue reported a bug doc-not-needed Your PR changes do not impact docs labels Nov 29, 2021
@lhotari lhotari self-assigned this Nov 29, 2021
@lhotari lhotari added this to the 2.10.0 milestone Nov 29, 2021
@lhotari
lhotari requested a review from eolivelli November 29, 2021 11:14

@nicoloboschi nicoloboschi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eolivelli

Copy link
Copy Markdown
Contributor

I looks like that this patch is only fixing the docker images.

what happens to people who try to download the pulsar binary tarball and try to run pulsar-perf ?
is it broken ?

@lhotari

lhotari commented Nov 29, 2021

Copy link
Copy Markdown
Member Author

I looks like that this patch is only fixing the docker images.

what happens to people who try to download the pulsar binary tarball and try to run pulsar-perf ? is it broken ?

Valid point. yes, the same problem exists in the binary tarball.

@lhotari

lhotari commented Nov 29, 2021

Copy link
Copy Markdown
Member Author

The reason why running the broker doesn't fail is the fact that the logs directory is always created

pulsar/bin/pulsar

Lines 292 to 294 in d3d580f

if [ ! -d "$PULSAR_LOG_DIR" ]; then
mkdir -p "$PULSAR_LOG_DIR"
fi

It feels wrong that pulsar-perf would have GC logging enabled by default.

@lhotari

lhotari commented Nov 29, 2021

Copy link
Copy Markdown
Member Author

I'm closing this PR and replacing with a broader refactoring of how the parameters are passed.

@lhotari lhotari closed this Nov 29, 2021
@lhotari

lhotari commented Nov 29, 2021

Copy link
Copy Markdown
Member Author

This is a better fix #13025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs type/bug The PR fixed a bug or issue reported a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants