[Security] Upgrade OkHttp3 to address CVE-2021-0341 - #13065
Merged
Conversation
* Upgrade OkHttp3 from 3.14.9 to 4.9.3 * Upgrade Okio to the same version of OkHttp3 4.9.3 * Override Okio transitive dependency - Kotlin stdlib - to 1.4.32 in order to address CVE-2020-29582
merlimat
approved these changes
Dec 1, 2021
lhotari
approved these changes
Dec 2, 2021
hezhangjian
approved these changes
Dec 2, 2021
dave2wave
reviewed
Dec 3, 2021
| <!-- keep using okhttp3 3.x for Presto --> | ||
| <okhttp3.version>3.14.9</okhttp3.version> | ||
| <!-- use okio version that matches the okhttp3 version --> | ||
| <okio.version>1.17.2</okio.version> |
Member
There was a problem hiding this comment.
Why is a different version of okio used in this pom from the main pom?
Contributor
Author
There was a problem hiding this comment.
this is the pom of presto-sql which is going to be moved to the presto repository (see PIP-62)
I don't want to introduce potential problems here, so I left the current version for okhttp3 and okio (for okio: I forced the same one used by okhttp3)
eolivelli
pushed a commit
that referenced
this pull request
Dec 15, 2021
* Upgrade OkHttp3 from 3.14.9 to 4.9.3 * Upgrade Okio to the same version of OkHttp3 4.9.3 * Override Okio transitive dependency - Kotlin stdlib - to 1.4.32 in order to address CVE-2020-29582 (cherry picked from commit d24faac)
fxbing
pushed a commit
to fxbing/pulsar
that referenced
this pull request
Dec 19, 2021
* Upgrade OkHttp3 from 3.14.9 to 4.9.3 * Upgrade Okio to the same version of OkHttp3 4.9.3 * Override Okio transitive dependency - Kotlin stdlib - to 1.4.32 in order to address CVE-2020-29582
Closed
1 task
1 task
nicoloboschi
added a commit
to datastax/pulsar
that referenced
this pull request
Mar 16, 2022
15 tasks
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Current OkHttp3 version - 3.14.9 - has an open CVE (https://nvd.nist.gov/vuln/detail/CVE-2021-0341) with a score of 7.5.
OkHttp3 is used by Java Kubernetes Client (currently only used by Pulsar Function Worker in "kubernetes" mode)
I upgraded to the latest stable release (4.9.3) where a fix for the CVE has been committed. The OkHttp3 team claims that 3.x and 4.x are fully compatibles (at least the java library)
Upgrading OkHttp3 and Okio, there is a new transitive dependency - Kotlin Standard Lib (licensed under Apache 2.0)
Unfortunately, the
kotlin-stdlibversion used by Okio and OkHttp3 has, in turn, a CVE open (https://nvd.nist.gov/vuln/detail/CVE-2020-29582); in order to not introduce another vulnerability, I've overridden the version with latest stable one (1.4.32)Modifications
Verifying this change
The change must be verified deploying and testing a Pulsar Function with
runtimeset tokubernetes. (I already performed this kind of test)Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
no-need-doc