Skip to content

[Tests] Remove unused mockZooKeeperClientFactory fields - #13093

Closed
lhotari wants to merge 1 commit into
apache:masterfrom
lhotari:lh-remove-unused-mockZooKeeperClientFactory-fields
Closed

[Tests] Remove unused mockZooKeeperClientFactory fields#13093
lhotari wants to merge 1 commit into
apache:masterfrom
lhotari:lh-remove-unused-mockZooKeeperClientFactory-fields

Conversation

@lhotari

@lhotari lhotari commented Dec 2, 2021

Copy link
Copy Markdown
Member

Motivation

There are unused mockZooKeeperClientFactory fields in a few test classes.

Modifications

Remove the unused mockZooKeeperClientFactory fields.

@lhotari lhotari added type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use doc-not-needed Your PR changes do not impact docs labels Dec 2, 2021
@lhotari
lhotari requested review from eolivelli and merlimat December 2, 2021 14:09
@lhotari lhotari self-assigned this Dec 2, 2021
@lhotari lhotari added this to the 2.10.0 milestone Dec 2, 2021
@merlimat

merlimat commented Dec 2, 2021

Copy link
Copy Markdown
Contributor

@lhotari I already have a change that does this and also removes the interface and implementations completely. It's pending on merging #13077.

@lhotari lhotari closed this Dec 2, 2021
@lhotari

lhotari commented Dec 2, 2021

Copy link
Copy Markdown
Member Author

Closed since #13077 handles this.

@lhotari
lhotari deleted the lh-remove-unused-mockZooKeeperClientFactory-fields branch December 2, 2021 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants