[Build] Fix modernizer-maven-plugin integration to Pulsar's build - #13168
Merged
lhotari merged 1 commit intoDec 7, 2021
Merged
Conversation
- the phase must be set to verify - unless this is specified, modernizer-maven-plugin will analyse outdated class files
lhotari
requested review from
315157973,
MarvinCai,
codelipenghui and
eolivelli
December 7, 2021 09:03
Contributor
|
这是来自QQ邮箱的自动回复邮件。
您好，邮件我已经收到，我将很快回复
|
|
@lhotari:Thanks for your contribution. For this PR, do we need to update docs? |
|
@lhotari:Thanks for providing doc info! |
Member
Author
@315157973 It seems that you have automatic email responses coming all the way back to GitHub issues. |
Member
Author
|
@nicoloboschi @eolivelli Please review |
1 task
Contributor
Sorry, I have shut it down |
nicoloboschi
approved these changes
Dec 7, 2021
Contributor
|
@MarvinCai PTAL |
fxbing
pushed a commit
to fxbing/pulsar
that referenced
this pull request
Dec 19, 2021
…ache#13168) - the phase must be set to verify - unless this is specified, modernizer-maven-plugin will analyse outdated class files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The current modernizer-maven-plugin integration to Pulsar's build is invalid. modernizer-maven-plugin will analyse outdated class files and this leads to obscure error messages.
Modifications
Additional context