[Proxy] Fix issue when Proxy fails to start and logs about an uncaught exception - #13171
Merged
Merged
Conversation
- happens at startup since the proxy client consumes 50% of number of available CPU cores for selectors
merlimat
approved these changes
Dec 7, 2021
fxbing
pushed a commit
to fxbing/pulsar
that referenced
this pull request
Dec 19, 2021
…t exception (apache#13171) * [Proxy] Print stacktrace in uncaught exception handler * [Proxy] Fix IllegalStateException: Insufficient configured threads - happens at startup since the proxy client consumes 50% of number of available CPU cores for selectors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The Pulsar proxy fails to start when deploying the master branch version of Pulsar with the Apache Pulsar Helm chart.
The proxy logs an obscure error message:
The reason why this happens is that the thread pool doesn't have sufficient amount of threads. Jetty reserves the threads from the main executor. The number of threads in the main executor can be configured with the
httpNumThreadsconfiguration parameter. (The workaround for the issue is to increase thehttpNumThreadsvalue until the proxy can start.)Modifications