[CI] Fix Tune Runner VM memory.swappiness no such file or directory - #13252
Merged
hangc0276 merged 1 commit intoDec 14, 2021
Merged
Conversation
…mory.swappiness: No such file or directory
Member
Author
|
/pulsarbot run-failure-checks |
1 similar comment
Member
Author
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Dec 13, 2021
codelipenghui
requested review from
315157973,
hangc0276,
lhotari and
merlimat
December 13, 2021 11:42
Contributor
|
@timmyyuan Please help review this PR. |
hangc0276
approved these changes
Dec 14, 2021
315157973
approved these changes
Dec 14, 2021
Demogorgon314
deleted the
fix/memory.swappiness_No_such_file_or_directory
branch
December 14, 2021 04:52
Member
|
This was the wrong solution to the problem. The change makes the shell script basically a no-op. The correct solution to the problem would have been to set Here's an example from the Pulsar CI refactoring: (
shopt -s nullglob
# Set swappiness to 1 for all cgroups and sub-groups
for swappiness_file in /sys/fs/cgroup/memory/*/memory.swappiness /sys/fs/cgroup/memory/*/*/memory.swappiness; do
echo 1 | sudo tee $swappiness_file > /dev/null
done
)I'll be including this fix as part of the Pulsar CI refactoring that I have announced on the dev mailing list. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failed CI: https://github.com/apache/pulsar/runs/4501006108?check_suite_focus=true#step:3:1
Motivation
The Tune Runner VM is flaky.
Sometimes, the parent directory of
memory.swappinesscan't find, we should check it first.Modifications
Add a check of the parent directory of
memory.swappinessDocumentation
no-need-doc