Fix incompatibility of BacklogQuota - #13291
Conversation
a862901 to
4723794
Compare
|
@shoothzj I noticed the fix only fixes the compatibility issue when getting backlog quota, I think another compatibility issue is when using a new version client >= 2.8 but the broker which < 2.8, since the broker-side don't have It's better to add a compatibility test to make sure we will not introduce breaking change for this part. Thanks for the great work. |
4723794 to
c81537a
Compare
|
@codelipenghui PTAL again, thanks |
|
@eolivelli @linlinnn PTAL, and should this cherry pick to 2.8 and 2.9 ? thanks |
|
Are we breaking compatibility with 2.8 ? 2.7 is far away, and the current release is 2.8... because IIUC we broke compatibility in 2.8 and now (we are at 2.9) it is too late |
|
I have now understood better the final outcome of this patch. |
(cherry picked from commit 4e89c2b)
# Conflicts: # pulsar-common/src/test/java/org/apache/pulsar/common/util/ObjectMapperFactoryTest.java # pulsar-metadata/src/test/java/org/apache/pulsar/metadata/BacklogQuotaCompatibilityTest.java
* Fix incompatibility of BacklogQuota (#13291) # Conflicts: # pulsar-common/src/test/java/org/apache/pulsar/common/util/ObjectMapperFactoryTest.java # pulsar-metadata/src/test/java/org/apache/pulsar/metadata/BacklogQuotaCompatibilityTest.java * Fix jar mentioned in lib/presto/LICENSE, but not bundled * Fix jar mentioned in lib/presto/LICENSE, but not bundled Co-authored-by: ZhangJian He <shoothzj@gmail.com>
Motivation
there is a change between pulsar2.7 and master
command
pulsar2.7 returns
but pulsar 2.9 returns
So we need a compat, let old REST/sdk user, can set and get
limitVerifying this change
org.apache.pulsar.broker.resources.NamespaceBacklogQuotaCompatibleTestfor testDocumentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
no-need-docIt's a compatibility bug fix.