[issue #13439][backlogQuota] Allow both limit and limitsize be null - #13557
Merged
Conversation
Member
Author
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Dec 30, 2021
codelipenghui
requested review from
315157973,
BewareMyPower,
MarvinCai,
gaoran10,
hangc0276 and
merlimat
December 30, 2021 11:03
315157973
approved these changes
Jan 7, 2022
hangc0276
approved these changes
Jan 7, 2022
codelipenghui
pushed a commit
that referenced
this pull request
Jan 10, 2022
…13557) Fixes #13439 ### Motivation Now we only constraint `limit` or `limitSize` be set on pulsar-admin, we don't limit it on rest endpoint. So there are situtations that both `limit` and `limitSize` be null ### Verifying this change This change added tests and can be verified as follows: - *Added test method in `BacklogQuotaCompatibilityTest` (cherry picked from commit 33491bc)
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13439
Motivation
Now we only constraint
limitorlimitSizebe set on pulsar-admin, we don't limit it on rest endpoint. So there are situtations that bothlimitandlimitSizebe nullVerifying this change
This change added tests and can be verified as follows:
BacklogQuotaCompatibilityTestDocumentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?
no-need-docbug fix, no need doc