Skip to content

Fix method is not safely accessed by multiple concurrent threads. #13725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shibd wants to merge 1 commit into from
Closed

Fix method is not safely accessed by multiple concurrent threads. #13725

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pulsar-metadata/src/main/java/org/apache/pulsar/metadata/cache/impl/MetadataCacheImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,12 +255,12 @@ public CompletableFuture<List<String>> getChildren(String path) {
}

@Override
public void invalidate(String path) {
public synchronized void invalidate(String path) {
objCache.synchronous().invalidate(path);
}

@Override
public void refresh(String path) {
public synchronized void refresh(String path) {
// Refresh object of path if only it is cached before.
if (objCache.getIfPresent(path) != null) {
objCache.synchronous().invalidate(path);
Expand All @@ -269,7 +269,7 @@ public void refresh(String path) {
}

@VisibleForTesting
public void invalidateAll() {
public synchronized void invalidateAll() {
objCache.synchronous().invalidateAll();
}

Expand Down