Skip to content

[Broker] Avoid call sync method in async rest API for reset cursor - #13841

Closed
nodece wants to merge 3 commits into
apache:masterfrom
nodece:fix_reset_cursor
Closed

[Broker] Avoid call sync method in async rest API for reset cursor#13841
nodece wants to merge 3 commits into
apache:masterfrom
nodece:fix_reset_cursor

Conversation

@nodece

@nodece nodece commented Jan 19, 2022

Copy link
Copy Markdown
Member

Signed-off-by: Zixuan Liu nodeces@gmail.com

Motivation

Avoid zk callback thread blocked, same with #13666

Modifications

  • Change sync method to async

Documentation

Need to update docs?

  • no-need-doc

@github-actions github-actions Bot added the doc-not-needed Your PR changes do not impact docs label Jan 19, 2022
@nodece
nodece marked this pull request as draft January 20, 2022 02:36
@nodece
nodece marked this pull request as ready for review January 24, 2022 14:49
@nodece nodece changed the title Avoid call sync method in async rest API for reset cursor [Broker] Avoid call sync method in async rest API for reset cursor Jan 24, 2022
@codelipenghui codelipenghui added this to the 2.10.0 milestone Jan 24, 2022
@nodece

nodece commented Jan 25, 2022

Copy link
Copy Markdown
Member Author

/pulsarbot rerun-failure-checks

@nodece
nodece force-pushed the fix_reset_cursor branch 3 times, most recently from 202e023 to 5747a19 Compare January 25, 2022 17:16
@nodece
nodece force-pushed the fix_reset_cursor branch 2 times, most recently from e477a17 to 73a7edf Compare January 26, 2022 08:19
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
@nodece

nodece commented Jan 28, 2022

Copy link
Copy Markdown
Member Author

/pulsarbot rerun-failure-checks

@github-actions

Copy link
Copy Markdown

The pr had no activity for 30 days, mark with Stale label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs lifecycle/stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants