Skip to content

[Broker] Fix call sync method in async rest api for internalUnloadTopic #13845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codelipenghui merged 5 commits into from
Jan 24, 2022
Merged

[Broker] Fix call sync method in async rest api for internalUnloadTopic #13845

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4113d92
[Broker] Fix call sync method in async rest api for internalUnloadTopic
mattisonchao Jan 20, 2022
c97cabc
Update pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/imp…
mattisonchao Jan 20, 2022
8de611a
Update pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/imp…
mattisonchao Jan 20, 2022
e94fef0
fixes some issue by review.
mattisonchao Jan 20, 2022
deac824
Update pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/imp…
mattisonchao Jan 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
203 changes: 101 additions & 102 deletions pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -714,70 +714,77 @@ protected void internalDeletePartitionedTopic(AsyncResponse asyncResponse, boole

protected void internalUnloadTopic(AsyncResponse asyncResponse, boolean authoritative) {
log.info("[{}] Unloading topic {}", clientAppId(), topicName);
try {
if (topicName.isGlobal()) {
validateGlobalNamespaceOwnership(namespaceName);
}
} catch (Exception e) {
log.error("[{}] Failed to unload topic {}", clientAppId(), topicName, e);
resumeAsyncResponseExceptionally(asyncResponse, e);
return;
}
// If the topic name is a partition name, no need to get partition topic metadata again
if (topicName.isPartitioned()) {
if (checkTopicIsTransactionCoordinatorAssign(topicName)) {
internalUnloadTransactionCoordinator(asyncResponse, authoritative);
} else {
internalUnloadNonPartitionedTopic(asyncResponse, authoritative);
}
CompletableFuture<Void> future;
if (topicName.isGlobal()) {
future = validateGlobalNamespaceOwnershipAsync(namespaceName);
} else {
getPartitionedTopicMetadataAsync(topicName, authoritative, false)
.thenAccept(meta -> {
if (meta.partitions > 0) {
final List<CompletableFuture<Void>> futures = Lists.newArrayList();

for (int i = 0; i < meta.partitions; i++) {
TopicName topicNamePartition = topicName.getPartition(i);
try {
futures.add(pulsar().getAdminClient().topics().unloadAsync(
topicNamePartition.toString()));
} catch (Exception e) {
log.error("[{}] Failed to unload topic {}", clientAppId(), topicNamePartition, e);
asyncResponse.resume(new RestException(e));
return;
}
}

FutureUtil.waitForAll(futures).handle((result, exception) -> {
if (exception != null) {
Throwable th = exception.getCause();
if (th instanceof NotFoundException) {
asyncResponse.resume(new RestException(Status.NOT_FOUND, th.getMessage()));
} else if (th instanceof WebApplicationException) {
asyncResponse.resume(th);
} else {
log.error("[{}] Failed to unload topic {}", clientAppId(), topicName,
exception);
asyncResponse.resume(new RestException(exception));
}
} else {
asyncResponse.resume(Response.noContent().build());
}
return null;
});
} else {
internalUnloadNonPartitionedTopic(asyncResponse, authoritative);
}
}).exceptionally(t -> {
log.error("[{}] Failed to unload topic {}", clientAppId(), topicName, t);
if (t instanceof WebApplicationException) {
asyncResponse.resume(t);
} else {
asyncResponse.resume(new RestException(t));
}
return null;
});
}
future = CompletableFuture.completedFuture(null);
}
future.thenAccept(__ -> {
// If the topic name is a partition name, no need to get partition topic metadata again
if (topicName.isPartitioned()) {
if (checkTopicIsTransactionCoordinatorAssign(topicName)) {
internalUnloadTransactionCoordinatorAsync(asyncResponse, authoritative);
} else {
internalUnloadNonPartitionedTopicAsync(asyncResponse, authoritative);
}
} else {
getPartitionedTopicMetadataAsync(topicName, authoritative, false)
.thenAccept(meta -> {
if (meta.partitions > 0) {
final List<CompletableFuture<Void>> futures =
Lists.newArrayListWithCapacity(meta.partitions);
for (int i = 0; i < meta.partitions; i++) {
TopicName topicNamePartition = topicName.getPartition(i);
try {
futures.add(pulsar().getAdminClient().topics().unloadAsync(
topicNamePartition.toString()));
} catch (Exception e) {
log.error("[{}] Failed to unload topic {}", clientAppId(),
topicNamePartition, e);
asyncResponse.resume(new RestException(e));
return;
}
}

FutureUtil.waitForAll(futures).handle((result, exception) -> {
if (exception != null) {
Throwable th = exception.getCause();
if (th instanceof NotFoundException) {
asyncResponse.resume(new RestException(Status.NOT_FOUND, th.getMessage()));
} else if (th instanceof WebApplicationException) {
asyncResponse.resume(th);
} else {
log.error("[{}] Failed to unload topic {}", clientAppId(), topicName,
exception);
asyncResponse.resume(new RestException(exception));
}
} else {
asyncResponse.resume(Response.noContent().build());
}
return null;
});
} else {
internalUnloadNonPartitionedTopicAsync(asyncResponse, authoritative);
}
}).exceptionally(t -> {
log.error("[{}] Failed to get partitioned metadata while unloading topic {}",
clientAppId(), topicName, t);
if (t instanceof WebApplicationException) {
asyncResponse.resume(t);
} else {
asyncResponse.resume(new RestException(t));
}
return null;
});
}
}).exceptionally(ex -> {
Throwable cause = ex.getCause();
log.error("[{}] Failed to validate the global namespace ownership while unloading topic {}",
clientAppId(), topicName, cause);
resumeAsyncResponseExceptionally(asyncResponse, cause);
return null;
});
}

protected CompletableFuture<DelayedDeliveryPolicies> internalGetDelayedDeliveryPolicies(boolean applied,
Expand Down Expand Up @@ -969,50 +976,42 @@ protected CompletableFuture<Void> internalSetDeduplicationSnapshotInterval(Integ
});
}

private void internalUnloadNonPartitionedTopic(AsyncResponse asyncResponse, boolean authoritative) {
try {
validateTopicOperation(topicName, TopicOperation.UNLOAD);
} catch (Exception e) {
log.error("[{}] Failed to unload topic {},{}", clientAppId(), topicName, e.getMessage());
resumeAsyncResponseExceptionally(asyncResponse, e);
return;
}

validateTopicOwnershipAsync(topicName, authoritative)
.thenCompose(__ -> getTopicReferenceAsync(topicName))
.thenCompose(topic -> topic.close(false))
.thenRun(() -> {
log.info("[{}] Successfully unloaded topic {}", clientAppId(), topicName);
asyncResponse.resume(Response.noContent().build());
})
private void internalUnloadNonPartitionedTopicAsync(AsyncResponse asyncResponse, boolean authoritative) {
validateTopicOperationAsync(topicName, TopicOperation.UNLOAD)
.thenCompose(unused -> validateTopicOwnershipAsync(topicName, authoritative)
.thenCompose(__ -> getTopicReferenceAsync(topicName))
.thenCompose(topic -> topic.close(false))
.thenRun(() -> {
log.info("[{}] Successfully unloaded topic {}", clientAppId(), topicName);
asyncResponse.resume(Response.noContent().build());
}))
.exceptionally(ex -> {
log.error("[{}] Failed to unload topic {}, {}", clientAppId(), topicName, ex.getMessage());
asyncResponse.resume(ex.getCause());
Throwable cause = ex.getCause();
log.error("[{}] Failed to unload topic {}, {}", clientAppId(), topicName, cause);
resumeAsyncResponseExceptionally(asyncResponse, cause);
return null;
});
}

private void internalUnloadTransactionCoordinator(AsyncResponse asyncResponse, boolean authoritative) {
try {
validateTopicOperation(topicName, TopicOperation.UNLOAD);
} catch (Exception e) {
log.error("[{}] Failed to unload tc {},{}", clientAppId(), topicName.getPartitionIndex(), e.getMessage());
resumeAsyncResponseExceptionally(asyncResponse, e);
return;
}
validateTopicOwnershipAsync(topicName, authoritative)
.thenCompose(v -> pulsar()
.getTransactionMetadataStoreService()
.removeTransactionMetadataStore(TransactionCoordinatorID.get(topicName.getPartitionIndex())))
.thenRun(() -> {
log.info("[{}] Successfully unloaded tc {}", clientAppId(), topicName.getPartitionIndex());
asyncResponse.resume(Response.noContent().build());
}).exceptionally(ex -> {
log.error("[{}] Failed to unload tc {}, {}", clientAppId(), topicName.getPartitionIndex(),
ex.getMessage());
asyncResponse.resume(ex.getCause());
return null;
});
private void internalUnloadTransactionCoordinatorAsync(AsyncResponse asyncResponse, boolean authoritative) {
validateTopicOperationAsync(topicName, TopicOperation.UNLOAD)

@codelipenghui codelipenghui Jan 20, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, looks like we make the wrong permission before, for the transaction coordinator, only the superuser can unload it. @congbobo184 Could you please help confirm?

@codelipenghui codelipenghui Jan 20, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ok to push a separate PR to fix this one, to make this PR more focus on what it wants to do

.thenCompose(__ -> validateTopicOwnershipAsync(topicName, authoritative)
.thenCompose(v -> pulsar()
.getTransactionMetadataStoreService()
.removeTransactionMetadataStore(
TransactionCoordinatorID.get(topicName.getPartitionIndex())))
.thenRun(() -> {
log.info("[{}] Successfully unloaded tc {}", clientAppId(),
topicName.getPartitionIndex());
asyncResponse.resume(Response.noContent().build());
}))
.exceptionally(ex -> {
Throwable cause = ex.getCause();
log.error("[{}] Failed to unload tc {},{}", clientAppId(),
topicName.getPartitionIndex(), cause);
resumeAsyncResponseExceptionally(asyncResponse, cause);
return null;
});
}

protected void internalDeleteTopic(boolean authoritative, boolean force, boolean deleteSchema) {
Expand Down