Fix: LockManagerTest.updateValue is flaky - #13850
Conversation
|
@Jason918 @Technoboy- @codelipenghui Hi, Can you help me review it again? Thanks. |
|
This PR looks the same as #13809, we can find this solution together. |
Thank you reply, I saw you fix the callback problem of ZKMetadata. I'll cancel this commit. However, the essential reason why this unit test will report an error is I think it can be handled like this:
|
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
|
@Jason918 @codelipenghui @nodece Sorry,The current changes have caused other problems. I will resubmit the PR in another way |
Motivation
#13663 Flaky-test: org.apache.pulsar.metadata.LockManagerTest.updateValue
The reasons are discussed in detail in this PR(#13725)
This is mainly caused by the callback method of
MetadataStoreand the concurrent access of the notification thread to theMetadataCache#refresh.We should queue them in the
metada-storethread pool(SingleThread)Modifications
AbstractMetadataStoremethod, all future callback opt are executed throughmetada-storethread.Documentation
no-need-doc