Skip to content

[DO NOT MERGE][Doc] add explanations for setting bookie rack name - #13874

Closed
Anonymitaet wants to merge 1 commit into
apache:masterfrom
Anonymitaet:0121
Closed

[DO NOT MERGE][Doc] add explanations for setting bookie rack name#13874
Anonymitaet wants to merge 1 commit into
apache:masterfrom
Anonymitaet:0121

Conversation

@Anonymitaet

@Anonymitaet Anonymitaet commented Jan 21, 2022

Copy link
Copy Markdown
Member
  1. Add docs for Fix invalid rack name cause bookie join rack failed #13683

    This doc should be added to the code file and shown on the pulsar-admin website automatically.

    However, pulsar-admin bookies are not rendered successfully. I've reported the issue and @urfreespace is investigating it.

    Consequently:

    • I add the docs to the CLI tool page first. If pulsar-admin bookies can be shown on the pulsar-admin website, I'll add the explanations to the code file and delete the explanations on the CLI tool page.
    • Though there are many other commands and flags, I only add explanations for the set-bookie-rack command and rack flag since this kind of content should be generated automatically rather than updating manually. Adding them here is to show an important reminder to users.
  2. Preview looks good:
    image

image

@Anonymitaet Anonymitaet added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Jan 21, 2022
@Anonymitaet Anonymitaet added this to the 2.10.0 milestone Jan 21, 2022
@Anonymitaet

Copy link
Copy Markdown
Member Author

@hangc0276 @Huanli-Meng @momo-jun could you please help review? Thanks

@hangc0276 hangc0276 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job.

@Anonymitaet Anonymitaet changed the title [Doc] add explanations for setting bookie rack name [DO NOT MERGE][Doc] add explanations for setting bookie rack name Jan 24, 2022
@Anonymitaet
Anonymitaet deleted the 0121 branch January 25, 2022 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants