[Broker] Fix read schema compatibility strategy priority by nodece · Pull Request #13938 · apache/pulsar

nodece · 2022-01-25T09:06:51Z

Signed-off-by: Zixuan Liu nodeces@gmail.com

Motivation

When we defined the schemaCompatibilityStrategy=ALWAYS_INCOMPATIBLE in broker.conf, and a namespace policies so like:

schema_auto_update_compatibility_strategy = SchemaAutoUpdateCompatibilityStrategy.Full
schema_compatibility_strategy = null

We should get SchemaCompatibilityStrategy.FULL by pulsar-admin namespaces get-schema-compatibility-strategy <ns>, but got SchemaCompatibilityStrategy.ALWAYS_INCOMPATIBLE, this is incorrect response.

Modifications

Use null as Policies#schema_auto_update_compatibility_strategy value
Use FULL as schemaCompatibilityStrategy value in broker.conf and update configuration code
Only return Policies#schema_compatibility_strategy when get schema compatibility strategy of namespace
Change the read schema compatibility strategy priority

Verifying this change

Make sure that the change passes the CI checks.

Documentation

doc-required - [Doc] Add schema configuration to conf file and reference documentation #13983

nodece · 2022-01-25T09:19:20Z

Hi @Jason918, could you take a look this?

nodece · 2022-01-26T03:35:35Z

/pulsarbot rerun-failure-checks

Signed-off-by: Zixuan Liu <nodeces@gmail.com>

congbobo184

LGTM

Signed-off-by: Zixuan Liu <nodeces@gmail.com> When we defined the `schemaCompatibilityStrategy=ALWAYS_INCOMPATIBLE` in `broker.conf`, and a namespace policies so like: ``` schema_auto_update_compatibility_strategy = SchemaAutoUpdateCompatibilityStrategy.Full schema_compatibility_strategy = null ``` We should get `SchemaCompatibilityStrategy.FULL` by `pulsar-admin namespaces get-schema-compatibility-strategy <ns>`, but got `SchemaCompatibilityStrategy.ALWAYS_INCOMPATIBLE`, this is incorrect response. - Use `null` as `Policies#schema_auto_update_compatibility_strategy` value - Use `FULL` as `schemaCompatibilityStrategy` value in `broker.conf` and update configuration code - Only return `Policies#schema_compatibility_strategy` when get schema compatibility strategy of namespace - Change the read schema compatibility strategy priority (cherry picked from commit c18d645)

Signed-off-by: Zixuan Liu <nodeces@gmail.com> ### Motivation When we defined the `schemaCompatibilityStrategy=ALWAYS_INCOMPATIBLE` in `broker.conf`, and a namespace policies so like: ``` schema_auto_update_compatibility_strategy = SchemaAutoUpdateCompatibilityStrategy.Full schema_compatibility_strategy = null ``` We should get `SchemaCompatibilityStrategy.FULL` by `pulsar-admin namespaces get-schema-compatibility-strategy <ns>`, but got `SchemaCompatibilityStrategy.ALWAYS_INCOMPATIBLE`, this is incorrect response. ### Modifications - Use `null` as `Policies#schema_auto_update_compatibility_strategy` value - Use `FULL` as `schemaCompatibilityStrategy` value in `broker.conf` and update configuration code - Only return `Policies#schema_compatibility_strategy` when get schema compatibility strategy of namespace - Change the read schema compatibility strategy priority (cherry picked from commit c18d645)

Signed-off-by: Zixuan Liu <nodeces@gmail.com> When we defined the `schemaCompatibilityStrategy=ALWAYS_INCOMPATIBLE` in `broker.conf`, and a namespace policies so like: ``` schema_auto_update_compatibility_strategy = SchemaAutoUpdateCompatibilityStrategy.Full schema_compatibility_strategy = null ``` We should get `SchemaCompatibilityStrategy.FULL` by `pulsar-admin namespaces get-schema-compatibility-strategy <ns>`, but got `SchemaCompatibilityStrategy.ALWAYS_INCOMPATIBLE`, this is incorrect response. - Use `null` as `Policies#schema_auto_update_compatibility_strategy` value - Use `FULL` as `schemaCompatibilityStrategy` value in `broker.conf` and update configuration code - Only return `Policies#schema_compatibility_strategy` when get schema compatibility strategy of namespace - Change the read schema compatibility strategy priority (cherry picked from commit c18d645)

Anonymitaet · 2022-02-07T08:27:31Z

@nodece are the docs added in #13983? If yes, can you link the code and the corresponding doc PR in the future? (so that others can see the changes clearly, thanks).

nodece · 2022-02-07T08:46:25Z

@Anonymitaet Done, thanks.

codelipenghui requested a review from congbobo184 January 25, 2022 09:08

codelipenghui assigned nodece Jan 25, 2022

codelipenghui added this to the 2.10.0 milestone Jan 25, 2022

codelipenghui added release/2.8.3 release/2.9.3 labels Jan 25, 2022

github-actions Bot added the doc-not-needed Your PR changes do not impact docs label Jan 25, 2022

codelipenghui reviewed Jan 25, 2022

View reviewed changes

Comment thread pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java Outdated

Comment thread pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java Outdated

nodece force-pushed the fix_schema_compatibility_strategy branch 2 times, most recently from 599c6f6 to 39e7749 Compare January 25, 2022 10:56

nodece requested a review from codelipenghui January 25, 2022 11:01

codelipenghui reviewed Jan 25, 2022

View reviewed changes

github-actions Bot added the doc-required Your PR changes impact docs and you will update later. label Jan 25, 2022

nodece force-pushed the fix_schema_compatibility_strategy branch from 39e7749 to 3e76c3e Compare January 25, 2022 17:03

nodece requested a review from codelipenghui January 25, 2022 17:03

nodece force-pushed the fix_schema_compatibility_strategy branch 3 times, most recently from 74c508f to 67719fe Compare January 26, 2022 02:49

congbobo184 reviewed Jan 26, 2022

View reviewed changes

Comment thread pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java Outdated

[Broker] Fix read schema compatibility strategy priority

9282042

Signed-off-by: Zixuan Liu <nodeces@gmail.com>

nodece force-pushed the fix_schema_compatibility_strategy branch from 67719fe to 9282042 Compare January 26, 2022 04:21

nodece requested a review from congbobo184 January 26, 2022 05:34

congbobo184 approved these changes Jan 26, 2022

View reviewed changes

codelipenghui approved these changes Jan 26, 2022

View reviewed changes

codelipenghui merged commit c18d645 into apache:master Jan 26, 2022

codelipenghui added cherry-picked/branch-2.8 Archived: 2.8 is end of life and removed cherry-picked/branch-2.8 Archived: 2.8 is end of life labels Jan 27, 2022

codelipenghui added the cherry-picked/branch-2.9 Archived: 2.9 is end of life label Jan 29, 2022

zymap added the cherry-picked/branch-2.8 Archived: 2.8 is end of life label Jan 30, 2022

Anonymitaet added doc-complete Your PR changes impact docs and the related docs have been already added. and removed doc-required Your PR changes impact docs and you will update later. labels Feb 7, 2022

nodece mentioned this pull request Feb 7, 2022

[Doc] Add schema configuration to conf file and reference documentation #13983

Merged

1 task

gaoran10 added release/2.9.2 area/broker and removed release/2.9.3 labels Feb 16, 2022

rdhabalia mentioned this pull request Nov 30, 2022

[improve][admin,broker] Add option to unloadNamespaceBundle with bundle Affinity broker url #18663

Merged

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Broker] Fix read schema compatibility strategy priority - #13938

[Broker] Fix read schema compatibility strategy priority#13938
codelipenghui merged 1 commit into
apache:masterfrom
nodece:fix_schema_compatibility_strategy

nodece commented Jan 25, 2022 •

edited

Loading

Uh oh!

nodece commented Jan 25, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nodece commented Jan 26, 2022

Uh oh!

Uh oh!

congbobo184 left a comment

Uh oh!

Anonymitaet commented Feb 7, 2022 •

edited

Loading

Uh oh!

nodece commented Feb 7, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

nodece commented Jan 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Modifications

Verifying this change

Documentation

Uh oh!

nodece commented Jan 25, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nodece commented Jan 26, 2022

Uh oh!

Uh oh!

congbobo184 left a comment

Choose a reason for hiding this comment

Uh oh!

Anonymitaet commented Feb 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodece commented Feb 7, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

nodece commented Jan 25, 2022 •

edited

Loading

Anonymitaet commented Feb 7, 2022 •

edited

Loading