Add OWASP Dependency Checker to the GH CI workflows - #13972
Conversation
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
eolivelli
left a comment
There was a problem hiding this comment.
Great stuff.
But I left one comment.
|
|
||
| name: CI - Misc - OWASP Dependency Check | ||
| on: | ||
| pull_request: |
There was a problem hiding this comment.
Why running this check on every pull request?
New dependencies are added very seldom.
If a dependency is flagged there will be much noise.
People usually add a new dependency using the latest available version.
I suggest to run this only periodically, like every day and manually on every active release branch
There was a problem hiding this comment.
@eolivelli this is only run when one of the pom.xml files is modified.
There was a problem hiding this comment.
in addition there's the existing job to run periodically
There was a problem hiding this comment.
@eolivelli as Lari said, it runs only on changes in pom files, see:
- name: Detect changed pom files
id: changes
uses: apache/pulsar-test-infra/paths-filter@master
with:
filters: |
poms:
- 'pom.xml'
- '**/pom.xml'
eolivelli
left a comment
There was a problem hiding this comment.
Thanks for your clarifications
Lgtm
|
+1 |
Motivation
Detect CVEs early and make them visible to the committers
Modifications
Added GH workflow that will fail if new CVE with level > 7 detected. The plan is to not treat it as blocking merge.
Currently some projects that will not pass the check and aren't included into the suppressions for variety of reasons are excluded.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)