[Managed-ledger]optimized constant naming convention#14004
Merged
hangc0276 merged 2 commits intoJan 29, 2022
Conversation
Contributor
Author
|
/pulsarbot run-failure-checks |
1 similar comment
Contributor
Author
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Jan 28, 2022
Contributor
Author
|
/pulsarbot run-failure-checks |
mattisonchao
approved these changes
Jan 29, 2022
Contributor
Author
|
/pulsarbot run-failure-checks |
hangc0276
approved these changes
Jan 29, 2022
BewareMyPower
added a commit
to streamnative/kop
that referenced
this pull request
Feb 14, 2022
Bump Pulsar version to 2.10.0.0-rc2 and fix the incompatibility issues introduced from apache/pulsar#14004 and apache/pulsar#12401.
BewareMyPower
added a commit
to streamnative/kop
that referenced
this pull request
Feb 14, 2022
Bump Pulsar version to 2.10.0.0-rc2 and fix the incompatibility issues introduced from apache/pulsar#14004 and apache/pulsar#12401. (cherry picked from commit 1e6826b)
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
### Motivation https://github.com/apache/pulsar/blob/af43e87d9a3bd9f18e56439521bab253cfc9ca40/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/NullLedgerOffloader.java#L32 modify to CONSTANT_CASE style. ### Modifications - *Use async instead of sync method.*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
pulsar/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/NullLedgerOffloader.java
Line 32 in af43e87
modify to CONSTANT_CASE style.
Modifications
Documentation
Need to update docs?
no-need-doc