[Broker] Set default value of applied to false in getSchemaCompatibilityStrategy - #14012
Merged
codelipenghui merged 1 commit intoJan 29, 2022
Merged
[Broker] Set default value of applied to false in getSchemaCompatibilityStrategy#14012codelipenghui merged 1 commit into
codelipenghui merged 1 commit into
Conversation
codelipenghui
approved these changes
Jan 28, 2022
mattisonchao
approved these changes
Jan 29, 2022
Jason918
approved these changes
Jan 29, 2022
Jason918
left a comment
Jason918
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
Just curious, is this applied implicitly default as false before this change?
Contributor
Author
Amdin Cli defaults |
Contributor
It's |
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In #13297, we should set default value of applied to
falsein getSchemaCompatibilityStrategyDocumentation
no-need-doc