[Management] Make BrokerBase#deleteDynamicConfiguration to pure async method. - #14163
Merged
codelipenghui merged 4 commits intoFeb 9, 2022
Merged
[Management] Make BrokerBase#deleteDynamicConfiguration to pure async method.#14163codelipenghui merged 4 commits into
BrokerBase#deleteDynamicConfiguration to pure async method.#14163codelipenghui merged 4 commits into
Conversation
Member
Author
|
@codelipenghui @lhotari @Technoboy- @Jason918 @RobertIndie @nodece PTAL, when you have time ~ :) |
Technoboy-
approved these changes
Feb 8, 2022
Technoboy-
reviewed
Feb 8, 2022
mattisonchao
commented
Feb 8, 2022
…l/BrokersBase.java
codelipenghui
approved these changes
Feb 8, 2022
Member
Author
|
/pulsarbot rerun-failure-checks |
Jason918
approved these changes
Feb 9, 2022
yuruguo
approved these changes
Feb 9, 2022
Member
@mattisonchao please share what these problems are. Is there a reported issue? |
2 tasks
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Make
BrokerBase#deleteDynamicConfigurationto a pure async method to avoid some problems caused by sync and async methods calling each other.Modifications
BrokerBase#deleteDynamicConfigurationto pure async method.metadatainstead ofzkin doc.Verifying this change
Documentation
no-need-doc