Skip to content

fix rackaware placement policy does not take effect after delete rack configuration #14248

Merged
eolivelli merged 5 commits into
apache:masterfrom
aloyszhang:rackaware-delete
Feb 15, 2022
Merged

fix rackaware placement policy does not take effect after delete rack configuration #14248
eolivelli merged 5 commits into
apache:masterfrom
aloyszhang:rackaware-delete

Conversation

@aloyszhang

@aloyszhang aloyszhang commented Feb 11, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes #14247

Motivation

fix rack aware placement policy does not take effect after deleting rack configuration

Modifications

  1. when bookie's rack configuration is deleted, notify EnsemblePlacementPolicy the delete change
  2. add test for rack update

Verifying this change

This change added tests and can be verified as follows: RackAwareTest.testRackUpdate()

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

  • no-need-doc

    (Please explain why)

@github-actions

github-actions Bot commented Feb 11, 2022

Copy link
Copy Markdown

@aloyszhang:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@aloyszhang aloyszhang added this to the 2.10.0 milestone Feb 11, 2022
@github-actions

github-actions Bot commented Feb 11, 2022

Copy link
Copy Markdown

@aloyszhang:Thanks for providing doc info!

@github-actions github-actions Bot added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Feb 11, 2022
@aloyszhang

aloyszhang commented Feb 12, 2022

Copy link
Copy Markdown
Contributor Author

/pulsarbot run-failure-checks

eolivelli
eolivelli reviewed Feb 12, 2022
View reviewed changes
Comment thread ...r-common/src/main/java/org/apache/pulsar/bookie/rackawareness/BookieRackAffinityMapping.java Outdated
Comment thread pulsar-broker/src/test/java/org/apache/pulsar/broker/service/RackAwareTest.java
Comment thread ...r-common/src/main/java/org/apache/pulsar/bookie/rackawareness/BookieRackAffinityMapping.java Outdated
@aloyszhang
aloyszhang requested a review from eolivelli February 13, 2022 02:03
eolivelli
eolivelli approved these changes Feb 13, 2022
View reviewed changes

@eolivelli eolivelli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@zymap
zymap requested review from hangc0276 and merlimat February 14, 2022 01:28
@codelipenghui codelipenghui modified the milestones: 2.10.0, 2.11.0 Feb 14, 2022
@aloyszhang

aloyszhang commented Feb 14, 2022

Copy link
Copy Markdown
Contributor Author

/pulsarbot run-failure-checks

@aloyszhang
aloyszhang requested a review from hangc0276 February 14, 2022 15:21
@eolivelli
eolivelli merged commit 891a98d into apache:master Feb 15, 2022
@lhotari lhotari mentioned this pull request Feb 15, 2022
Closed
@codelipenghui codelipenghui modified the milestones: 2.11.0, 2.10.0 Feb 17, 2022
@aloyszhang
aloyszhang deleted the rackaware-delete branch February 28, 2022 08:16
Nicklee007 pushed a commit to Nicklee007/pulsar that referenced this pull request Apr 20, 2022
@aloyszhang nicklixinyang
fix rackaware placement policy does not take effect after delete rack…
b45ffb5 
… configuration (apache#14248)
@lhotari lhotari mentioned this pull request Jun 2, 2022
Open
@BewareMyPower BewareMyPower mentioned this pull request Jul 29, 2022
Merged
1 task
aloyszhang added a commit to aloyszhang/pulsar that referenced this pull request Nov 30, 2022
@aloyszhang mayozhang
fix rackaware placement policy does not take effect after delete rack…
cb704cc 
… configuration (apache#14248)
@TakaHiR07 TakaHiR07 mentioned this pull request Aug 7, 2023
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hangc0276 hangc0276 hangc0276 approved these changes
@eolivelli eolivelli eolivelli approved these changes
@merlimat merlimat Awaiting requested review from merlimat
@codelipenghui codelipenghui Awaiting requested review from codelipenghui

Assignees

@aloyszhang aloyszhang

Labels

doc-not-needed Your PR changes do not impact docs

Projects

None yet

Milestone

2.10.0

Development

Successfully merging this pull request may close these issues.

Delete rack configurations does not take effect for RackAware Placement Policy

4 participants

@aloyszhang @hangc0276 @eolivelli @codelipenghui