Skip to content

[CI] Remove owasp-dep-check from required checks - #14512

Merged
eolivelli merged 1 commit into
apache:masterfrom
lhotari:lh-owasp-check-not-required
Mar 1, 2022
Merged

[CI] Remove owasp-dep-check from required checks#14512
eolivelli merged 1 commit into
apache:masterfrom
lhotari:lh-owasp-check-not-required

Conversation

@lhotari

@lhotari lhotari commented Mar 1, 2022

Copy link
Copy Markdown
Member

Motivation

  • OWASP dependency check shouldn't be a required check
    • when a new vulnerability occurs, it blocks all PRs that change pom.xml
      files if his check is a required check.

Modifications

  • remove owasp-dep-check from required checks

- OWASP dependency check shouldn't be a required check
  - when a new vulnerability occurs, it blocks all PRs that change pom.xml
    files if his check is a required check.
@lhotari lhotari added area/build doc-not-needed Your PR changes do not impact docs area/ci labels Mar 1, 2022
@lhotari
lhotari requested a review from michaeljmarshall March 1, 2022 12:35
@lhotari lhotari self-assigned this Mar 1, 2022
@lhotari
lhotari requested a review from eolivelli March 1, 2022 13:53
@lhotari

lhotari commented Mar 1, 2022

Copy link
Copy Markdown
Member Author

It seems that owasp-dep-check has never cleanly passed and this blocks PRs which make pom.xml changes. Example of blocked PR: #14509 .
More details of owasp-dep-check issue.

@eolivelli eolivelli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@eolivelli
eolivelli merged commit 8ec2954 into apache:master Mar 1, 2022
Nicklee007 pushed a commit to Nicklee007/pulsar that referenced this pull request Apr 20, 2022
- OWASP dependency check shouldn't be a required check
  - when a new vulnerability occurs, it blocks all PRs that change pom.xml
    files if his check is a required check.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/build area/ci doc-not-needed Your PR changes do not impact docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants