Skip to content

Refactored to reflect changes in BK for OrderedExecutor - #1489

Merged
merlimat merged 3 commits into
apache:masterfrom
merlimat:ordered-executor
Apr 3, 2018
Merged

Refactored to reflect changes in BK for OrderedExecutor#1489
merlimat merged 3 commits into
apache:masterfrom
merlimat:ordered-executor

Conversation

@merlimat

@merlimat merlimat commented Apr 3, 2018

Copy link
Copy Markdown
Contributor

Motivation

Recently merged improvements in BookKeeper OrderedExecutor (see apache/bookkeeper#1309 ). We need to update Pulsar code with the refactored names.

@merlimat merlimat added this to the 2.0.0-incubating milestone Apr 3, 2018
@merlimat merlimat self-assigned this Apr 3, 2018
@merlimat
merlimat requested review from jai1, rdhabalia and sijie April 3, 2018 05:10
@sijie

sijie commented Apr 3, 2018

Copy link
Copy Markdown
Member

retest this please

@jai1

jai1 commented Apr 3, 2018

Copy link
Copy Markdown
Contributor

retest this please

@jai1 jai1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we will always run into these issues as long as we keep pointing to SNAPSHOT jar.

Maybe we should eventually stop using BK SNAPSHOT jar.

@merlimat

merlimat commented Apr 3, 2018

Copy link
Copy Markdown
Contributor Author

I guess we will always run into these issues as long as we keep pointing to SNAPSHOT jar.
Maybe we should eventually stop using BK SNAPSHOT jar.

Yes, once we're sure BK 4.7 is ready and has all the pieces we need for Pulsar, a release will be made and we'll switch to that release. That should happen soon.

There were a lot of thing that we had to adjust on both Pulsar and BK side to make the transition to 4.7, it wasn't just possible to make these changes in a branch and sync with master.

@rdhabalia rdhabalia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add timestamp snapshot version for BK.

@merlimat

merlimat commented Apr 3, 2018

Copy link
Copy Markdown
Contributor Author

can we add timestamp snapshot version for BK.

We can, though I don't think it needs to be part of this PR

@rdhabalia
rdhabalia dismissed their stale review April 3, 2018 21:48

we will do it later

@merlimat
merlimat merged commit d309b2c into apache:master Apr 3, 2018
@merlimat
merlimat deleted the ordered-executor branch April 3, 2018 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants