[CI] Remove required checks workaround from pulsar-ci.yaml - #14955
Merged
Conversation
- remove workaround from pulsar-ci.yaml which was needed to make the required checks pass
lhotari
requested review from
dave2wave,
eolivelli,
merlimat and
michaeljmarshall
March 30, 2022 19:00
michaeljmarshall
approved these changes
Mar 30, 2022
dave2wave
approved these changes
Mar 30, 2022
dave2wave
left a comment
dave2wave
left a comment
Member
There was a problem hiding this comment.
LGTM - let's unstick the beast
Member
|
Looks some tests failed. |
mattisonchao
approved these changes
Mar 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifications
the required checks pass. Workaround isn't needed after [CI] Change the required checks to match refactored Pulsar CI #14944 changes to
.asf.yaml.