[improve][Rest api]Remove duplication validateTopicOwnershipAsync - #15120
Merged
Jason918 merged 1 commit intoApr 21, 2022
Merged
Conversation
gaozhangmin
requested review from
BewareMyPower,
Jason918,
codelipenghui and
gaoran10
and removed request for
codelipenghui
April 11, 2022 11:55
|
@gaozhangmin:Thanks for your contribution. For this PR, do we need to update docs? |
|
@gaozhangmin:Thanks for providing doc info! |
gaozhangmin
force-pushed
the
remove-duplication-validateTopicOwnershipAsync
branch
from
April 11, 2022 12:40
5a5762a to
d1405af
Compare
Contributor
Author
|
/pulsarbot run-failure-checks |
gaozhangmin
force-pushed
the
remove-duplication-validateTopicOwnershipAsync
branch
from
April 15, 2022 02:11
d1405af to
1e64bb6
Compare
Contributor
Author
|
@Technoboy- PTAL Thx. |
Technoboy-
approved these changes
Apr 18, 2022
Technoboy-
left a comment
Technoboy-
left a comment
Contributor
There was a problem hiding this comment.
LTGM.
@mattisonchao Please help review.
1 task
codelipenghui
pushed a commit
that referenced
this pull request
Apr 28, 2022
Co-authored-by: gavingaozhangmin <gavingaozhangmin@didiglobal.com> (cherry picked from commit 151f1d1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
eg, method
internalGetSubscriptionsinvokesvalidateTopicOwnershipAsynctwice, because methodinternalGetSubscriptionsForNonPartitionedTopicalso invokedvalidateTopicOwnershipAsync.Modifications
Removed
validateTopicOwnershipAsynccall in method internalGetSubscriptionsForNonPartitionedTopic.Documentation
Check the box below or label this PR directly.
Need to update docs?
no-need-doc(Please explain why)