Removed contention between producers on ManagedLedger addEntry#1521
Merged
Conversation
merlimat
added
the
type/enhancement
sijie
approved these changes
Apr 9, 2018
merlimat
added a commit
to merlimat/pulsar
that referenced
this pull request
Apr 11, 2018
sijie
pushed a commit
that referenced
this pull request
Apr 12, 2018
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When there are multiple producers writing on the same topic and there are many entries/second (little batching), there can be thread contention when doing
managedLedger.addEntry().Modifications
Result
This will remove the contention on both the
ManagedLedgerand the BKLedgerHandlermutexes.