[fix][tools] Only apply maxPendingMessagesAcrossPartitions if it presents - #15283
Merged
Technoboy- merged 1 commit intoApr 24, 2022
Merged
Conversation
…ents ### Motivation After apache#13344, we have changed the default value of maxPendingMessagesAcrossPartitions to `0`, for the performance producer, it will always apply the default value of maxPendingMessagesAcrossPartitions while creating producers, so it will always use `0` for maxPendingMessagesAcrossPartitions. But we have a check here https://github.com/apache/pulsar/blob/0a91196dcc4d31ae647867ed319b8c1af0cb93c6/pulsar-client/src/main/java/org/apache/pulsar/client/impl/conf/ProducerConfigurationData.java#L138-L142 This will lead the performance producer not able to create if users only set `-o` option ``` 06:32:49.628 [pulsar-perf-producer-exec-1-1] ERROR org.apache.pulsar.testclient.PerformanceProducer - Got error java.lang.IllegalArgumentException: maxPendingMessagesAcrossPartitions needs to be >= maxPendingMessages at org.apache.pulsar.shade.com.google.common.base.Preconditions.checkArgument(Preconditions.java:145) ~[pulsar-client-admin-2.10.0.2.jar:2.10.0.2] at org.apache.pulsar.client.impl.conf.ProducerConfigurationData.setMaxPendingMessagesAcrossPartitions(ProducerConfigurationData.java:138) ~[pulsar-client-admin-2.10.0.2.jar:2.10.0.2] at org.apache.pulsar.client.impl.ProducerBuilderImpl.maxPendingMessagesAcrossPartitions(ProducerBuilderImpl.java:148) ~[pulsar-client-admin-2.10.0.2.jar:2.10.0.2] at org.apache.pulsar.testclient.PerformanceProducer.runProducer(PerformanceProducer.java:600) ~[pulsar-testclient-2.10.0.2.jar:2.10.0.2] at org.apache.pulsar.testclient.PerformanceProducer.lambda$main$1(PerformanceProducer.java:464) ~[pulsar-testclient-2.10.0.2.jar:2.10.0.2] at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [?:1.8.0_332] at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:1.8.0_332] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) [?:1.8.0_332] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) [?:1.8.0_332] at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) [netty-common-4.1.74.Final.jar:4.1.74.Final] at java.lang.Thread.run(Thread.java:750) [?:1.8.0_332] ``` ### Modification Change the performance producer to only call `.maxPendingMessagesAcrossPartitions()` if it presents. ### Verification Added new test to only use `-o` to start the performance producer, use a consumer to consume data from the topic to make sure the performance producer has been created successfully.
|
@codelipenghui:Thanks for your contribution. For this PR, do we need to update docs? |
1 similar comment
|
@codelipenghui:Thanks for your contribution. For this PR, do we need to update docs? |
RobertIndie
approved these changes
Apr 24, 2022
nodece
approved these changes
Apr 24, 2022
Technoboy-
approved these changes
Apr 24, 2022
315157973
approved these changes
Apr 24, 2022
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 9, 2022
…ents (apache#15283) (cherry picked from commit 188d4f4) (cherry picked from commit bdb6203)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
After #13344, we have changed the default value of maxPendingMessagesAcrossPartitions to
0,for the performance producer, it will always apply the default value of maxPendingMessagesAcrossPartitions
while creating producers, so it will always use
0for maxPendingMessagesAcrossPartitions.But we have a check here
pulsar/pulsar-client/src/main/java/org/apache/pulsar/client/impl/conf/ProducerConfigurationData.java
Lines 138 to 142 in 0a91196
This will lead the performance producer not able to create if users only set
-ooptionModification
Change the performance producer to only call
.maxPendingMessagesAcrossPartitions()if it presents.Verification
Added a new test to only use
-oto start the performance producer, use a consumer to consume data fromthe topic to make sure the performance producer has been created successfully.
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below or label this PR directly.
Need to update docs?
doc-required(Your PR needs to update docs and you will update later)
no-need-doc(Please explain why)
doc(Your PR contains doc changes)
doc-added(Docs have been already added)