[pulsar-client-cpp] Upgrade protobuf - #15344
Merged
Merged
Conversation
kimula
force-pushed
the
fix-upgrade-protobuf
branch
from
April 27, 2022 08:09
9414174 to
2d803ab
Compare
kimula
force-pushed
the
fix-upgrade-protobuf
branch
from
April 27, 2022 08:24
2d803ab to
aa64dc1
Compare
kimula
marked this pull request as ready for review
April 27, 2022 08:36
Contributor
Could you verify the Dockerfile locally before pushing the patch? It looks like we shouldn't modify the path to |
Contributor
Author
|
@BewareMyPower I undid an unneccessary change of |
BewareMyPower
approved these changes
May 12, 2022
zymap
added a commit
to zymap/pulsar
that referenced
this pull request
May 30, 2022
This reverts commit 8fdec2f.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
protobuf 3.3.0 is vulnerable.
https://snyk.io/vuln/pip:protobuf
Modifications
upgrade the version of protobuf in pulsar-client-cpp to 3.20.0.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below or label this PR directly.
Need to update docs?
no-need-doc